Bug 1148521

Summary: Memory leaks in ec while traversing directories
Product: [Community] GlusterFS Reporter: Xavi Hernandez <jahernan>
Component: disperseAssignee: Xavi Hernandez <jahernan>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.6.0CC: bugs, gluster-bugs
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.6.1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1148520 Environment:
Last Closed: 2014-11-10 15:14:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1148520    
Bug Blocks: 1117822    

Description Xavi Hernandez 2014-10-01 15:56:24 UTC
+++ This bug was initially created as a clone of Bug #1148520 +++

Description of problem:

When many directories are scanned, mount and brick processes increase memory usage without limit.

Version-Release number of selected component (if applicable): master


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2014-10-01 19:48:09 UTC
REVIEW: http://review.gluster.org/8896 (ec: Fix memory leak caused by undestroyed fops) posted (#2) for review on master by Xavier Hernandez (xhernandez)

Comment 2 Anand Avati 2014-10-01 19:51:53 UTC
REVIEW: http://review.gluster.org/8897 (ec: Fix memory leak caused by undestroyed fops) posted (#1) for review on release-3.6 by Xavier Hernandez (xhernandez)

Comment 3 Anand Avati 2014-10-03 09:02:15 UTC
COMMIT: http://review.gluster.org/8897 committed in release-3.6 by Vijay Bellur (vbellur) 
------
commit 58aba738ef73fae01748ddf49c3f7ad03ecf733c
Author: Xavier Hernandez <xhernandez>
Date:   Wed Oct 1 20:41:58 2014 +0200

    ec: Fix memory leak caused by undestroyed fops
    
    Operations processed by ec_dispatch_one() were not correctly
    completed by ec_complete(), leaving some structures in memory.
    
    Now ec_complete() also calls ec_resume() for this type of fops.
    
    This is a backport of http://review.gluster.org/8896/
    
    Change-Id: Iaf0f2e8227399ebb735db9f1bd007593e0ece041
    BUG: 1148521
    Signed-off-by: Xavier Hernandez <xhernandez>
    Reviewed-on: http://review.gluster.org/8897
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Dan Lambright <dlambrig>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 4 Niels de Vos 2014-11-10 15:14:02 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users