Bug 1148657

Summary:	Review Request: python-astor - Read/rewrite/write Python ASTs
Product:	[Fedora] Fedora	Reporter:	Jens Petersen <petersen>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-06-12 15:36:23 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1148749

Description Jens Petersen 2014-10-02 04:08:47 UTC

Spec URL: http://petersen.fedorapeople.org/reviews/python-astor.spec
SRPM URL: http://petersen.fedorapeople.org/reviews/python-astor-0.4-1.fc20.src.rpm

Description:
A python library for manipulation of Python source via the AST.

PyPI: https://pypi.python.org/pypi/astor
Documentation: http://astor.rtfd.org/

Comment 1 Jens Petersen 2014-10-02 04:08:50 UTC

This package built on koji:  http://koji.fedoraproject.org/koji/taskinfo?taskID=7745182

Comment 2 Mario Blättermann 2015-03-28 21:12:46 UTC

Some initial comments:

According to PKG-INFO, it also builds with Python 3, and that one will become the default next time in Fedora:
http://fedoraproject.org/wiki/Changes/Python_3_as_Default#Current_status
So I recommend to either build both versions, or only the Python 3 one, depending on your needs for python-hy.

python-devel is deprecated, use python2-devel or python3-devel instead:
http://fedoraproject.org/wiki/Packaging:Python#BuildRequires

LICENSE is no longer part of %doc, we need it in %license:
http://fedoraproject.org/wiki/Changes/Use_license_macro_in_RPMs_for_packages_in_Cloud_Image

There is a stray whitespace character in line 13 of your spec file.