Bug 1148657 - Review Request: python-astor - Read/rewrite/write Python ASTs
Summary: Review Request: python-astor - Read/rewrite/write Python ASTs
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1148749
TreeView+ depends on / blocked
 
Reported: 2014-10-02 04:08 UTC by Jens Petersen
Modified: 2019-06-12 15:36 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-06-12 15:36:23 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Jens Petersen 2014-10-02 04:08:47 UTC
Spec URL: http://petersen.fedorapeople.org/reviews/python-astor.spec
SRPM URL: http://petersen.fedorapeople.org/reviews/python-astor-0.4-1.fc20.src.rpm

Description:
A python library for manipulation of Python source via the AST.

PyPI: https://pypi.python.org/pypi/astor
Documentation: http://astor.rtfd.org/

Comment 1 Jens Petersen 2014-10-02 04:08:50 UTC
This package built on koji:  http://koji.fedoraproject.org/koji/taskinfo?taskID=7745182

Comment 2 Mario Blättermann 2015-03-28 21:12:46 UTC
Some initial comments:

According to PKG-INFO, it also builds with Python 3, and that one will become the default next time in Fedora:
http://fedoraproject.org/wiki/Changes/Python_3_as_Default#Current_status
So I recommend to either build both versions, or only the Python 3 one, depending on your needs for python-hy.

python-devel is deprecated, use python2-devel or python3-devel instead:
http://fedoraproject.org/wiki/Packaging:Python#BuildRequires

LICENSE is no longer part of %doc, we need it in %license:
http://fedoraproject.org/wiki/Changes/Use_license_macro_in_RPMs_for_packages_in_Cloud_Image

There is a stray whitespace character in line 13 of your spec file.


Note You need to log in before you can comment on or make changes to this bug.