Bug 1149641 (xcat)
| Summary: | Review Request: xcat - A command line tool to explore blind XPath injection vulnerabilities | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | johnny, package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | xcat-0.7.1-1.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-11-13 18:17:47 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1148935, 1148946, 1148982 | ||
| Bug Blocks: | 563471 | ||
|
Description
Fabian Affolter
2014-10-06 10:24:04 UTC
Review: + Package builds fine in mock (f22 x86_64) + rpmlint on generated rpms gave output xcat.noarch: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically xcat.noarch: W: no-manual-page-for-binary xcat xcat.src: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically 2 packages and 0 specfiles checked; 0 errors, 3 warnings. + Source verified with upstream as (sha256sum) upstream tarball: 7c55be7ef20a91c69715ec64ce288ac9c893c2a3107e86dd405fdeaa690f6dca srpm tarball : 7c55be7ef20a91c69715ec64ce288ac9c893c2a3107e86dd405fdeaa690f6dca + License "MIT" is valid and included in LICENSE file. Suggestions: 1) macro srcname is not defined in spec file. Please add it. 2) this package should be named as python3-xcat (In reply to Parag AN(पराग) from comment #1) > 2) this package should be named as python3-xcat I disagree. xcat is a tool which is written in python and not a python module. Sorry I got it wrong before. You are right this is tool actually. APPROVED. Thanks for the review. New Package SCM Request ======================= Package Name: xcat Short Description: A command line tool to explore blind XPath injection vulnerabilities Upstream URL: https://github.com/orf/xcat Owners: fab Branches: f20 f21 epel7 InitialCC: Git done (by process-git-requests). xcat-0.7.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/xcat-0.7.1-1.fc21 xcat-0.7.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/xcat-0.7.1-1.fc20 xcat-0.7.1-1.fc20 has been pushed to the Fedora 20 testing repository. shouldn't this package depend on python 3.4 or a python3-asyncio asyncio package? I don't see how it would work out of the box on a fedora 20 install. sorry. i commented on the wrong package. :( xcat-0.7.1-1.fc20 has been pushed to the Fedora 20 stable repository. xcat-0.7.1-1.fc21 has been pushed to the Fedora 21 stable repository. |