Spec URL: https://fab.fedorapeople.org/packages/SRPMS/xcat.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/xcat-0.7.1-1.fc22.src.rpm Project URL: https://github.com/orf/xcat Description: XCat is a command line program that aides in the exploitation of blind XPath injection vulnerabilities. It can be used to retrieve the whole XML document being processed by a vulnerable XPath query, read arbitrary files on the hosts filesystem and utilize out of bound HTTP requests to make the server send data directly to xcat. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7774127 rpmlint output: [fab@localhost SRPMS]$ rpmlint xcat-0.7.1-1.fc22.src.rpm xcat.src: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [fab@localhost noarch]$ rpmlint xcat-0.7.1-1.fc22.noarch.rpm xcat.noarch: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically xcat.noarch: W: no-manual-page-for-binary xcat 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Fedora Account System Username: fab
Review: + Package builds fine in mock (f22 x86_64) + rpmlint on generated rpms gave output xcat.noarch: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically xcat.noarch: W: no-manual-page-for-binary xcat xcat.src: W: spelling-error %description -l en_US filesystem -> file system, file-system, systemically 2 packages and 0 specfiles checked; 0 errors, 3 warnings. + Source verified with upstream as (sha256sum) upstream tarball: 7c55be7ef20a91c69715ec64ce288ac9c893c2a3107e86dd405fdeaa690f6dca srpm tarball : 7c55be7ef20a91c69715ec64ce288ac9c893c2a3107e86dd405fdeaa690f6dca + License "MIT" is valid and included in LICENSE file. Suggestions: 1) macro srcname is not defined in spec file. Please add it. 2) this package should be named as python3-xcat
(In reply to Parag AN(पराग) from comment #1) > 2) this package should be named as python3-xcat I disagree. xcat is a tool which is written in python and not a python module.
Sorry I got it wrong before. You are right this is tool actually. APPROVED.
Thanks for the review.
New Package SCM Request ======================= Package Name: xcat Short Description: A command line tool to explore blind XPath injection vulnerabilities Upstream URL: https://github.com/orf/xcat Owners: fab Branches: f20 f21 epel7 InitialCC:
Git done (by process-git-requests).
xcat-0.7.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/xcat-0.7.1-1.fc21
xcat-0.7.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/xcat-0.7.1-1.fc20
xcat-0.7.1-1.fc20 has been pushed to the Fedora 20 testing repository.
shouldn't this package depend on python 3.4 or a python3-asyncio asyncio package? I don't see how it would work out of the box on a fedora 20 install.
sorry. i commented on the wrong package. :(
xcat-0.7.1-1.fc20 has been pushed to the Fedora 20 stable repository.
xcat-0.7.1-1.fc21 has been pushed to the Fedora 21 stable repository.