Bug 1150973

Summary: [origin_devexp_325]Corrupted strings display in build log which is returned by command openshift kube buildLogs
Product: OKD Reporter: Wenjing Zheng <wzheng>
Component: ContainersAssignee: Jakub Hadvig <jhadvig>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: low Docs Contact:
Priority: medium    
Version: 2.xCC: jhadvig, jokerman, mmccomas
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-03-05 19:55:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1157616    
Bug Blocks:    
Attachments:
Description Flags
Please refer to this screenshot for corrupted strings
none
Corrupted strings also displays in container log none

Description Wenjing Zheng 2014-10-09 10:44:28 UTC
Created attachment 945257 [details]
Please refer to this screenshot for corrupted strings

Description of problem:
When try to get build log with command openshift kube buildLogs --id="$build_id", there are some squares display in the beginning of each line.(will attach a screenshot to prove this)

Version-Release number of selected component (if applicable):
devenv-fedora_231

How reproducible:
always

Steps to Reproduce:
1.Start openshift
2.Push a build
3.Get the build log 
$openshift kube buildLogs --id="$build_id"

Actual results:
There are square in the beginning of each line in returned build log.

Expected results:
It should display correctly with correct format.

Additional info:

Comment 1 Wenjing Zheng 2014-10-10 03:31:23 UTC
Created attachment 945461 [details]
Corrupted strings also displays in container log

Comment 2 Jakub Hadvig 2014-11-12 10:53:01 UTC
The problem is in the RawTerminal attribute of LogOptions in k8s/kubelet/dockertools/docker.go#350. After switching to false the build logs will appear in a correct format.

Already send a PR to k8s upstream. 
https://github.com/GoogleCloudPlatform/kubernetes/pull/2324

Could you please test the change and confirm that its working? 

Thanks

Comment 3 Wenjing Zheng 2015-02-04 06:30:14 UTC
Verified on devenv-fedora_684. No corrupted strings coming out.