Bug 1150973 - [origin_devexp_325]Corrupted strings display in build log which is returned by command openshift kube buildLogs
Summary: [origin_devexp_325]Corrupted strings display in build log which is returned b...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OKD
Classification: Red Hat
Component: Containers
Version: 2.x
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ---
: ---
Assignee: Jakub Hadvig
QA Contact: libra bugs
URL:
Whiteboard:
Depends On: 1157616
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-10-09 10:44 UTC by Wenjing Zheng
Modified: 2015-05-14 23:13 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-03-05 19:55:34 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Please refer to this screenshot for corrupted strings (395.64 KB, image/png)
2014-10-09 10:44 UTC, Wenjing Zheng
no flags Details
Corrupted strings also displays in container log (377.73 KB, image/png)
2014-10-10 03:31 UTC, Wenjing Zheng
no flags Details

Description Wenjing Zheng 2014-10-09 10:44:28 UTC
Created attachment 945257 [details]
Please refer to this screenshot for corrupted strings

Description of problem:
When try to get build log with command openshift kube buildLogs --id="$build_id", there are some squares display in the beginning of each line.(will attach a screenshot to prove this)

Version-Release number of selected component (if applicable):
devenv-fedora_231

How reproducible:
always

Steps to Reproduce:
1.Start openshift
2.Push a build
3.Get the build log 
$openshift kube buildLogs --id="$build_id"

Actual results:
There are square in the beginning of each line in returned build log.

Expected results:
It should display correctly with correct format.

Additional info:

Comment 1 Wenjing Zheng 2014-10-10 03:31:23 UTC
Created attachment 945461 [details]
Corrupted strings also displays in container log

Comment 2 Jakub Hadvig 2014-11-12 10:53:01 UTC
The problem is in the RawTerminal attribute of LogOptions in k8s/kubelet/dockertools/docker.go#350. After switching to false the build logs will appear in a correct format.

Already send a PR to k8s upstream. 
https://github.com/GoogleCloudPlatform/kubernetes/pull/2324

Could you please test the change and confirm that its working? 

Thanks

Comment 3 Wenjing Zheng 2015-02-04 06:30:14 UTC
Verified on devenv-fedora_684. No corrupted strings coming out.


Note You need to log in before you can comment on or make changes to this bug.