Bug 1151457

Summary: Use items() instead of iteritems() with Python 3 dicts
Product: [Fedora] Fedora Reporter: Marek Kašík <mkasik>
Component: system-config-printerAssignee: Tim Waugh <twaugh>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 21CC: jpopelka, twaugh
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: system-config-printer-1.5.2-2.fc21 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-10-14 04:43:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Use items() instead of iteritems() with Python 3 dicts none

Description Marek Kašík 2014-10-10 13:10:26 UTC
Created attachment 945597 [details]
Use items() instead of iteritems() with Python 3 dicts

Description of problem:
There is one more usage of iteritems() which needs to be changed to items() in GroupPhysicalDevicesRequest's _group().


Version-Release number of selected component (if applicable):
system-config-printer-1.5.1-3.fc21.x86_64


How reproducible:
always


Steps to Reproduce:
1. try to add a printer in gnome-control-center

Actual results:
(gnome-control-center:22064): printers-cc-panel-WARNING **: GDBus.Error:org.freedesktop.DBus.Python.AttributeError: Traceback (most recent call last):
  File "/usr/share/system-config-printer/scp-dbus-service.py", line 250, in _group
    for device_uri, deviceobj in self.deviceobjs.iteritems ():
AttributeError: 'dict' object has no attribute 'iteritems'


Expected results:
no error


Additional info:
See attached patch.

Comment 1 Tim Waugh 2014-10-10 16:17:36 UTC
Thanks, applied upstream.

Comment 2 Fedora Update System 2014-10-10 16:44:31 UTC
system-config-printer-1.5.2-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/system-config-printer-1.5.2-2.fc21

Comment 3 Fedora Update System 2014-10-11 06:58:00 UTC
Package system-config-printer-1.5.2-2.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing system-config-printer-1.5.2-2.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-12631/system-config-printer-1.5.2-2.fc21
then log in and leave karma (feedback).

Comment 4 Fedora Update System 2014-10-14 04:43:15 UTC
system-config-printer-1.5.2-2.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.