Bug 1151457 - Use items() instead of iteritems() with Python 3 dicts
Summary: Use items() instead of iteritems() with Python 3 dicts
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: system-config-printer
Version: 21
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Tim Waugh
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-10-10 13:10 UTC by Marek Kašík
Modified: 2014-10-14 04:43 UTC (History)
2 users (show)

Fixed In Version: system-config-printer-1.5.2-2.fc21
Clone Of:
Environment:
Last Closed: 2014-10-14 04:43:15 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Use items() instead of iteritems() with Python 3 dicts (950 bytes, application/mbox)
2014-10-10 13:10 UTC, Marek Kašík
no flags Details

Description Marek Kašík 2014-10-10 13:10:26 UTC
Created attachment 945597 [details]
Use items() instead of iteritems() with Python 3 dicts

Description of problem:
There is one more usage of iteritems() which needs to be changed to items() in GroupPhysicalDevicesRequest's _group().


Version-Release number of selected component (if applicable):
system-config-printer-1.5.1-3.fc21.x86_64


How reproducible:
always


Steps to Reproduce:
1. try to add a printer in gnome-control-center

Actual results:
(gnome-control-center:22064): printers-cc-panel-WARNING **: GDBus.Error:org.freedesktop.DBus.Python.AttributeError: Traceback (most recent call last):
  File "/usr/share/system-config-printer/scp-dbus-service.py", line 250, in _group
    for device_uri, deviceobj in self.deviceobjs.iteritems ():
AttributeError: 'dict' object has no attribute 'iteritems'


Expected results:
no error


Additional info:
See attached patch.

Comment 1 Tim Waugh 2014-10-10 16:17:36 UTC
Thanks, applied upstream.

Comment 2 Fedora Update System 2014-10-10 16:44:31 UTC
system-config-printer-1.5.2-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/system-config-printer-1.5.2-2.fc21

Comment 3 Fedora Update System 2014-10-11 06:58:00 UTC
Package system-config-printer-1.5.2-2.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing system-config-printer-1.5.2-2.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-12631/system-config-printer-1.5.2-2.fc21
then log in and leave karma (feedback).

Comment 4 Fedora Update System 2014-10-14 04:43:15 UTC
system-config-printer-1.5.2-2.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.