Bug 1151816 (nodejs-replace)
| Summary: | Review Request: nodejs-replace - Command line search and replace utility using Nodejs | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dan Callaghan <dcallagh> |
| Component: | Package Review | Assignee: | Lubomir Rintel <lkundrak> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | lkundrak, lrintel, package-review |
| Target Milestone: | --- | Flags: | lrintel:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | nodejs-replace-0.3.0-2.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-12-06 10:30:54 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1151815 | ||
| Bug Blocks: | 1151817 | ||
|
Description
Dan Callaghan
2014-10-12 05:05:44 UTC
* Named correctly * Versioned correctly * Latest version packaged * License tag correct ! License text not included * License good for fedora * SPEC file clean and legible, follows nodejs guidelines * Filelist sane * Requires/provides make sense * rpmlint happy Please drop the LICENSE file from another package, it's of no use. Looking at the upstream GitHub project it seems that the maintainer is more likely to merge a pull request than respond to a bug report? I'm wondering if you could do a pull request instead and explain why is it important to ship the license text in the commit message? Thank you. (In reply to Lubomir Rintel from comment #1) > Looking at the upstream GitHub project it seems that the maintainer is more > likely to merge a pull request than respond to a bug report? I'm wondering > if you could do a pull request instead and explain why is it important to > ship the license text in the commit message? Yes good point, done: https://github.com/harthur/replace/pull/43 (In reply to Dan Callaghan from comment #2) > https://github.com/harthur/replace/pull/43 This is merged now. https://fedorapeople.org/~dcallagh/nodejs-replace/nodejs-replace.spec https://fedorapeople.org/~dcallagh/nodejs-replace/nodejs-replace-0.3.0-2.fc21.src.rpm Looks good now, thank you! APPROVED New Package SCM Request ======================= Package Name: nodejs-replace Short Description: Command line search and replace utility using Nodejs Upstream URL: https://github.com/harthur/replace Owners: dcallagh Branches: f21 epel7 InitialCC: Git done (by process-git-requests). nodejs-replace-0.3.0-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-replace-0.3.0-2.fc21 nodejs-replace-0.3.0-2.fc21 has been pushed to the Fedora 21 testing repository. nodejs-replace-0.3.0-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-replace-0.3.0-2.el7 nodejs-replace-0.3.0-2.fc21 has been pushed to the Fedora 21 stable repository. nodejs-replace-0.3.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository. |