Spec URL: https://fedorapeople.org/~dcallagh/nodejs-replace/nodejs-replace.spec SRPM URL: https://fedorapeople.org/~dcallagh/nodejs-replace/nodejs-replace-0.3.0-1.fc21.src.rpm Description: replace is a command line utility for performing search-and-replace on files. It's similar to sed but there are a few differences: * Modifies files when matches are found * Recursive search on directories with -r * Uses JavaScript syntax for regular expressions and replacement strings. Fedora Account System Username: dcallagh
* Named correctly * Versioned correctly * Latest version packaged * License tag correct ! License text not included * License good for fedora * SPEC file clean and legible, follows nodejs guidelines * Filelist sane * Requires/provides make sense * rpmlint happy Please drop the LICENSE file from another package, it's of no use. Looking at the upstream GitHub project it seems that the maintainer is more likely to merge a pull request than respond to a bug report? I'm wondering if you could do a pull request instead and explain why is it important to ship the license text in the commit message? Thank you.
(In reply to Lubomir Rintel from comment #1) > Looking at the upstream GitHub project it seems that the maintainer is more > likely to merge a pull request than respond to a bug report? I'm wondering > if you could do a pull request instead and explain why is it important to > ship the license text in the commit message? Yes good point, done: https://github.com/harthur/replace/pull/43
(In reply to Dan Callaghan from comment #2) > https://github.com/harthur/replace/pull/43 This is merged now. https://fedorapeople.org/~dcallagh/nodejs-replace/nodejs-replace.spec https://fedorapeople.org/~dcallagh/nodejs-replace/nodejs-replace-0.3.0-2.fc21.src.rpm
Looks good now, thank you! APPROVED
New Package SCM Request ======================= Package Name: nodejs-replace Short Description: Command line search and replace utility using Nodejs Upstream URL: https://github.com/harthur/replace Owners: dcallagh Branches: f21 epel7 InitialCC:
Git done (by process-git-requests).
nodejs-replace-0.3.0-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-replace-0.3.0-2.fc21
nodejs-replace-0.3.0-2.fc21 has been pushed to the Fedora 21 testing repository.
nodejs-replace-0.3.0-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-replace-0.3.0-2.el7
nodejs-replace-0.3.0-2.fc21 has been pushed to the Fedora 21 stable repository.
nodejs-replace-0.3.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository.