Bug 1151900

Summary: Should also add a field for directory files when run virt-ls with --csv option
Product: Red Hat Enterprise Linux 7 Reporter: Lingfei Kong <lkong>
Component: libguestfsAssignee: Richard W.M. Jones <rjones>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: low Docs Contact:
Priority: medium    
Version: 7.1CC: jherrman, leiwang, mbooth, ptoscano, wshi, yuliu
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libguestfs-1.28.1-1.2.el7 Doc Type: Enhancement
Doc Text:
The output of the "virt-ls --csv --checksum" command now always includes a field for the checksum value, even if the field is empty, like in the case of directories. As a result, the command's output is more easily parseable.
Story Points: ---
Clone Of:
: 1151901 (view as bug list) Environment:
Last Closed: 2015-03-05 13:46:14 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1151901    

Description Lingfei Kong 2014-10-13 02:34:14 UTC
Description of problem:
Should also add a field for directory files when run virt-ls with --csv option
All lines in a csv file should have the same number of fields.


Version-Release number of selected component (if applicable):
libguestfs-1.27.62-1.1.el7


How reproducible:
100%


Steps to Reproduce:
#virt-ls -a rhel.img /etc -Rl --csv --checksum


Actual results:
.....
d,0755,4096,/etc/yum.repos.d
-,0644,529,16dfc405ffa10c1853c5a3271fdb2758,/etc/yum.repos.d/rhel-source.repo
-,0644,138,a680b678bcd7c6dd386ddf0f86633c00,/etc/yum.repos.d/rhel6.repo


Expected results:
.....
d,0755,4096,,/etc/yum.repos.d
-,0644,529,16dfc405ffa10c1853c5a3271fdb2758,/etc/yum.repos.d/rhel-source.repo
-,0644,138,a680b678bcd7c6dd386ddf0f86633c00,/etc/yum.repos.d/rhel6.repo


Additional info:

Comment 1 Pino Toscano 2014-10-13 13:52:18 UTC
Patch posted:
https://www.redhat.com/archives/libguestfs/2014-October/msg00095.html

Comment 4 Lingfei Kong 2014-10-22 02:37:47 UTC
Verified with libguestfs-tools-c-1.28.1-1.2.el7

#virt-ls -a rhel.img /etc -Rl --csv --checksum | egrep ^d
d,0755,12288,,/etc
d,0755,4096,,/etc/.java
d,0755,4096,,/etc/.java/.systemPrefs
d,0755,4096,,/etc/ConsoleKit
d,0755,4096,,/etc/ConsoleKit/run-seat.d
d,0755,4096,,/etc/ConsoleKit/run-session.d
d,0755,4096,,/etc/ConsoleKit/seats.d
d,0755,4096,,/etc/NetworkManager
d,0755,4096,,/etc/NetworkManager/dispatcher.d
d,0755,4096,,/etc/X11
d,0755,4096,,/etc/X11/applnk
d,0755,4096,,/etc/X11/fontpath.d
d,0755,4096,,/etc/abrt
d,0755,4096,,/etc/abrt/plugins
d,0755,4096,,/etc/acpi
d,0755,4096,,/etc/acpi/actions
d,0755,4096,,/etc/acpi/events
d,0755,4096,,/etc/alsa
d,0755,4096,,/etc/alternatives
d,0750,4096,,/etc/audisp
......



#virt-ls -a rhel.img /etc -Rl --csv --checksum | egrep ^d | awk -F',' '{print NF}' |sort|uniq
5

Comment 6 errata-xmlrpc 2015-03-05 13:46:14 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0303.html