Bug 1151943
| Summary: | Do not use 'mock --shell' for non-interactive scripts | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miroslav Suchý <msuchy> | ||||
| Component: | fedora-review | Assignee: | Stanislav Ochotnicky <sochotni> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | rawhide | CC: | amigadave, leamas.alec, pingou, piotr1212, pnemade, sochotni | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | fedora-review-0.5.2-2.fc20 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2015-01-26 02:35:38 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Miroslav Suchý
2014-10-13 07:09:52 UTC
Additonally passing mock --shell foo --someopt will evaluate --someopt as argument to mock. And unless you want shell expansion it is better to use --chroot. So you should either mock --chroot 'foo --someopt' or mock --chroot -- foo --someopt And btw current code does not work with mock, so I'm raising Priority Created attachment 980402 [details]
Proposed patch to resolve this issue
I have applied the patch to upstream (thanks!). Had to fix a few other test cases failing but that's all set so I'll have a look at updated packages. fedora-review-0.5.2-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/fedora-review-0.5.2-2.fc20 fedora-review-0.5.2-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/fedora-review-0.5.2-2.fc21 fedora-review-0.5.2-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/fedora-review-0.5.2-2.el6 Package fedora-review-0.5.2-2.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing fedora-review-0.5.2-2.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-0974/fedora-review-0.5.2-2.fc21 then log in and leave karma (feedback). fedora-review-0.5.2-2.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. *** Bug 1185672 has been marked as a duplicate of this bug. *** fedora-review-0.5.2-2.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. |