Bug 1152246

Summary: Review Request: joda-timezones - Timezone data for joda-time
Product: [Fedora] Fedora Reporter: Mo Morsi <mmorsi>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: msrb, package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-07-11 00:46:58 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 201449, 1152249    

Description Mo Morsi 2014-10-13 17:22:54 UTC
Spec URL: https://mmorsi.fedorapeople.org/staging/joda-timezones.spec
SRPM URL: https://mmorsi.fedorapeople.org/staging/joda-timezones-2013d-1.fc20.src.rpm
Description: 
Timezone data for joda-time

Fedora Account System Username: mmorsi

Comment 1 Michael Simacek 2014-10-14 13:42:02 UTC
Issues:
- Upstream URL doesn't exist
- Source0 URL doesn't exist
- Missing BR exec-maven-plugin and joda-time
- Missing period at the end of description
- Undetermined license - ask upstream to include it
- Incorrect changelog format - missing version-release
- Group tag is obsolete, remove it
- Outdated timezone data (2013)
- Spec file as given by url is not the same as in SRPM

Comment 2 Mo Morsi 2014-10-14 17:56:55 UTC
Thx for review. Mostly copy-n-paste errors.

Spec URL: https://mmorsi.fedorapeople.org/staging/joda-timezones.spec
SRPM URL: https://mmorsi.fedorapeople.org/staging/joda-timezones-2013d-2.fc20.src.rpm
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7864861

(In reply to Michael Simacek from comment #1)
> Issues:
> - Upstream URL doesn't exist
> - Source0 URL doesn't exist
> - Missing BR exec-maven-plugin and joda-time
> - Missing period at the end of description

Fixed all of these

> - Undetermined license - ask upstream to include it

https://github.com/jruby/joda-timezones/issues/2

> - Incorrect changelog format - missing version-release
> - Group tag is obsolete, remove it

Fixed these

> - Outdated timezone data (2013)

This is what the upstream release uses so figure it'd best to go w/ this to mitigate any unexpected consequences.


> - Spec file as given by url is not the same as in SRPM

Fixed

Comment 3 Michal Srb 2015-02-17 08:39:46 UTC
(In reply to Mo Morsi from comment #2)
> 
> > - Undetermined license - ask upstream to include it
> 
> https://github.com/jruby/joda-timezones/issues/2
> 

The whole jruby/joda-timezones project is just sophisticated way of doing:

java -Dorg.joda.time.DateTimeZone.Provider=org.joda.time.tz.UTCProvider -cp `build-classpath joda-time` org.joda.time.tz.ZoneInfoCompiler -src target/tzdata -dst target/classes/org/joda/time/tz/data africa antarctica asia australasia europe northamerica southamerica pacificnew etcetera backward systemv

And packaging the result into JAR.

So if upstream doesn't respond to the ticket, there is an easy workaround.

Comment 4 Michael Simacek 2015-05-20 14:14:08 UTC
Upstream doesn't seem to be responding. What do you think about the alternative proposed by Michal?

Comment 5 Package Review 2020-07-10 00:50:52 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 6 Package Review 2020-07-11 00:46:58 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.