Spec URL: https://mmorsi.fedorapeople.org/staging/joda-timezones.spec SRPM URL: https://mmorsi.fedorapeople.org/staging/joda-timezones-2013d-1.fc20.src.rpm Description: Timezone data for joda-time Fedora Account System Username: mmorsi
Issues: - Upstream URL doesn't exist - Source0 URL doesn't exist - Missing BR exec-maven-plugin and joda-time - Missing period at the end of description - Undetermined license - ask upstream to include it - Incorrect changelog format - missing version-release - Group tag is obsolete, remove it - Outdated timezone data (2013) - Spec file as given by url is not the same as in SRPM
Thx for review. Mostly copy-n-paste errors. Spec URL: https://mmorsi.fedorapeople.org/staging/joda-timezones.spec SRPM URL: https://mmorsi.fedorapeople.org/staging/joda-timezones-2013d-2.fc20.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7864861 (In reply to Michael Simacek from comment #1) > Issues: > - Upstream URL doesn't exist > - Source0 URL doesn't exist > - Missing BR exec-maven-plugin and joda-time > - Missing period at the end of description Fixed all of these > - Undetermined license - ask upstream to include it https://github.com/jruby/joda-timezones/issues/2 > - Incorrect changelog format - missing version-release > - Group tag is obsolete, remove it Fixed these > - Outdated timezone data (2013) This is what the upstream release uses so figure it'd best to go w/ this to mitigate any unexpected consequences. > - Spec file as given by url is not the same as in SRPM Fixed
(In reply to Mo Morsi from comment #2) > > > - Undetermined license - ask upstream to include it > > https://github.com/jruby/joda-timezones/issues/2 > The whole jruby/joda-timezones project is just sophisticated way of doing: java -Dorg.joda.time.DateTimeZone.Provider=org.joda.time.tz.UTCProvider -cp `build-classpath joda-time` org.joda.time.tz.ZoneInfoCompiler -src target/tzdata -dst target/classes/org/joda/time/tz/data africa antarctica asia australasia europe northamerica southamerica pacificnew etcetera backward systemv And packaging the result into JAR. So if upstream doesn't respond to the ticket, there is an easy workaround.
Upstream doesn't seem to be responding. What do you think about the alternative proposed by Michal?
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.