Bug 1152897

Summary:	Review Request: python-ndg_httpsclient - Provides enhanced HTTPS support for httplib and urllib2 using PyOpenSSL
Product:	[Fedora] Fedora	Reporter:	Miro Hrončok <mhroncok>
Component:	Package Review	Assignee:	Bohuslav "Slavek" Kabrda <bkabrda>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	bkabrda, package-review
Target Milestone:	---	Flags:	bkabrda: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	python-ndg_httpsclient-0.3.2-1.el7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-11-10 06:02:22 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Miro Hrončok 2014-10-15 07:27:16 UTC

Spec URL: https://raw.githubusercontent.com/hroncok/SPECS/master/python-ndg-httpsclient.spec
SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-ndg-httpsclient-0.3.2-1.fc20.src.rpm

Description:
This is a HTTPS client implementation for httplib and urllib2 based on
PyOpenSSL. PyOpenSSL provides a more fully featured SSL implementation
over the default provided with Python and importantly enables full
verification of the SSL peer.

Fedora Account System Username: churchyard

Note: Does not work with Python 3 and generally has no obvious purpose there anyway, because the SSL implementation in Python 3 is "good enough".

Comment 1 Bohuslav "Slavek" Kabrda 2014-10-15 12:20:50 UTC

Taking this for review.

Comment 2 Bohuslav "Slavek" Kabrda 2014-10-15 12:37:44 UTC

- You should use python2-devel, not python-devel [1]
- I think you shouldn't replace the underscore in package name. [2] says, that "packages where the upstream name naturally contains an underscore" aren't supposed to replace underscore with dash.

Otherwise the package looks good, so once you fix these, I can approve.

[1] https://fedoraproject.org/wiki/Packaging:Python#BuildRequires
[2] https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Separators

Comment 3 Miro Hrončok 2014-10-15 13:02:21 UTC

Fixed the name, python2-devel. Also noticed the module uses entrypoints so requiring setuptools for runtime as well.

Spec URL: https://raw.githubusercontent.com/hroncok/SPECS/master/python-ndg_httpsclient.spec
SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-ndg_httpsclient-0.3.2-1.fc20.src.rpm

Comment 4 Bohuslav "Slavek" Kabrda 2014-10-15 13:08:48 UTC

Everything seems to be fine, APPROVED.

Comment 5 Miro Hrončok 2014-10-15 13:10:54 UTC

New Package SCM Request
=======================
Package Name: python-ndg_httpsclient
Short Description: Provides enhanced HTTPS support for httplib and urllib2 using PyOpenSSL
Upstream URL: http://ndg-security.ceda.ac.uk/wiki/ndg_httpsclient/
Owners: churchyard
Branches: f21 epel7

Comment 6 Gwyn Ciesla 2014-10-30 12:24:32 UTC

Git done (by process-git-requests).

Comment 7 Fedora Update System 2014-10-31 10:45:41 UTC

python-ndg_httpsclient-0.3.2-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/python-ndg_httpsclient-0.3.2-1.el7

Comment 8 Fedora Update System 2014-10-31 10:46:29 UTC

python-ndg_httpsclient-0.3.2-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/python-ndg_httpsclient-0.3.2-1.fc21

Comment 9 Fedora Update System 2014-11-01 16:50:15 UTC

python-ndg_httpsclient-0.3.2-1.fc21 has been pushed to the Fedora 21 testing repository.

Comment 10 Fedora Update System 2014-11-10 06:02:22 UTC

python-ndg_httpsclient-0.3.2-1.fc21 has been pushed to the Fedora 21 stable repository.

Comment 11 Fedora Update System 2014-11-18 08:11:42 UTC

python-ndg_httpsclient-0.3.2-1.el7 has been pushed to the Fedora EPEL 7 stable repository.