Spec URL: https://raw.githubusercontent.com/hroncok/SPECS/master/python-ndg-httpsclient.spec SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-ndg-httpsclient-0.3.2-1.fc20.src.rpm Description: This is a HTTPS client implementation for httplib and urllib2 based on PyOpenSSL. PyOpenSSL provides a more fully featured SSL implementation over the default provided with Python and importantly enables full verification of the SSL peer. Fedora Account System Username: churchyard Note: Does not work with Python 3 and generally has no obvious purpose there anyway, because the SSL implementation in Python 3 is "good enough".
Taking this for review.
- You should use python2-devel, not python-devel [1] - I think you shouldn't replace the underscore in package name. [2] says, that "packages where the upstream name naturally contains an underscore" aren't supposed to replace underscore with dash. Otherwise the package looks good, so once you fix these, I can approve. [1] https://fedoraproject.org/wiki/Packaging:Python#BuildRequires [2] https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Separators
Fixed the name, python2-devel. Also noticed the module uses entrypoints so requiring setuptools for runtime as well. Spec URL: https://raw.githubusercontent.com/hroncok/SPECS/master/python-ndg_httpsclient.spec SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-ndg_httpsclient-0.3.2-1.fc20.src.rpm
Everything seems to be fine, APPROVED.
New Package SCM Request ======================= Package Name: python-ndg_httpsclient Short Description: Provides enhanced HTTPS support for httplib and urllib2 using PyOpenSSL Upstream URL: http://ndg-security.ceda.ac.uk/wiki/ndg_httpsclient/ Owners: churchyard Branches: f21 epel7
Git done (by process-git-requests).
python-ndg_httpsclient-0.3.2-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/python-ndg_httpsclient-0.3.2-1.el7
python-ndg_httpsclient-0.3.2-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-ndg_httpsclient-0.3.2-1.fc21
python-ndg_httpsclient-0.3.2-1.fc21 has been pushed to the Fedora 21 testing repository.
python-ndg_httpsclient-0.3.2-1.fc21 has been pushed to the Fedora 21 stable repository.
python-ndg_httpsclient-0.3.2-1.el7 has been pushed to the Fedora EPEL 7 stable repository.