Bug 1153844

Summary:	Redundancy whitespace at the end of directory name when use <TAB> to complete the directory name in guestfish with a xfs filesystem in guest
Product:	Red Hat Enterprise Linux 7	Reporter:	Lingfei Kong <lkong>
Component:	libguestfs	Assignee:	Richard W.M. Jones <rjones>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	low	Docs Contact:
Priority:	low
Version:	7.1	CC:	jherrman, leiwang, mbooth, ptoscano, wshi, yuliu
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libguestfs-1.28.1-1.7.el7	Doc Type:	Bug Fix
Doc Text:	Using Tab-completion in guestfish on guests with the XFS file system did not correctly append the slash ("/") symbol to directory names. This update adjusts guestfish to properly distinguish files and directories on this file system, and thus fixes the problem.	Story Points:	---
Clone Of:
Clones:	1153846 (view as bug list)		Environment:
Last Closed:	2015-03-05 13:46:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1153846

Description Lingfei Kong 2014-10-17 00:52:46 UTC

Description of problem:
Redundancy whitespace at the end of directory name when use <TAB> to complete the directory name in guestfish with a xfs filesystem in guest. It works well with ext2/3/4 btrfs filesystem. 


Version-Release number of selected component (if applicable):
libguestfs-tools-c-1.27.63-1.1.el7


How reproducible:
100%


Steps to Reproduce:
#guestfish -N fs:xfs
><fs> mount /dev/sda1 /
><fs> mkdir /test
><fs> ls /test 


Actual results:
><fs> ls /test 

There is a whitespace at the end of /test


Expected results:
><fs> ls /test/


Additional info:

Comment 1 Pino Toscano 2014-10-31 16:56:52 UTC

This is something that bothered me for a while, but I haven't found a reliable way to reproduce it. Indeed the file system (xfs in this case) is the key; patch posted:
  https://www.redhat.com/archives/libguestfs/2014-October/msg00258.html

Comment 2 Pino Toscano 2014-10-31 17:17:16 UTC

Fixed upstream with commit
https://github.com/libguestfs/libguestfs/commit/a8b95a5535480c7b382fab82dcaf18eb67e5278a
which is in libguestfs >= 1.29.4.

Comment 4 yuliu 2014-11-11 08:07:21 UTC

Version: libguestfs-1.28.1-1.9.el7.x86_64

Steps:
><fs> ls /test/ 
><fs> 

works fine. Verified.

Comment 6 errata-xmlrpc 2015-03-05 13:46:38 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0303.html