Bug 1154213
| Summary: | Review Request: python-structlog - Painless structural logging | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Piotr Popieluch <piotr1212> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | python-structlog-0.4.2-5.el7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-11-10 17:52:46 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1154743 | ||
| Bug Blocks: | 1154218 | ||
|
Description
Piotr Popieluch
2014-10-17 22:00:36 UTC
A couple of quick comments: http://www.structlog.org/en/0.4.2/ [...] structlog targets Python 2.6, 2.7, 3.2, 3.3, and PyPy with no additional dependencies for core functionality. Please consider building a python3 subpackage as well if you can at least test if it works properly. Either way, please use %{__python2} instead of %{__python}. The upstream source contains a test suite. Please run it in %check. Thanks for reviewing. I've updated the spec to create both python2 and python3. I've also added the %check section which introduced a new missing library, python-pretend, see https://bugzilla.redhat.com/show_bug.cgi?id=1154743 Spec URL: http://vps533.directvps.nl/python-structlog.spec SRPM URL: http://vps533.directvps.nl/python-structlog-0.4.2-2.fc20.src.rpm I've also done two more reviews: https://bugzilla.redhat.com/show_bug.cgi?id=1147351 https://bugzilla.redhat.com/show_bug.cgi?id=1150734 Review: + Package built successful in mock (f22 x86_64) + rpmlint on generated rpms gave output 3 packages and 0 specfiles checked; 0 errors, 0 warnings. + Source verified with upstream as sha256sum srpm tarball: 45a6e7ba0e1f335822cf24e14b95d9590fe13e9e2a6abe58a099638037e84377 upstream tarball: 45a6e7ba0e1f335822cf24e14b95d9590fe13e9e2a6abe58a099638037e84377 + License is ASL 2.0 and included in LICENSE file + follow python packaging guidelines Suggestions: 1) Group tag is optional 2) License tag is missing for python3-structlog sub-package 3) %files section should be more verbose like in your other approved packages. Thanks for the review
- Removed group
- Removed shipped .egg-info
- Added license to python3 package
- Made %%files section more verbose
- Replaced %%{python_sitelib} with %%{python2_sitelib}
bumped to release 3:
Spec URL: http://vps533.directvps.nl/python-structlog.spec
SRPM URL: http://vps533.directvps.nl/python-structlog-0.4.2-3.fc20.src.rpm
Looks good APPROVED. New Package SCM Request ======================= Package Name: python-structlog Short Description: Painless structural logging Upstream URL: http://www.structlog.org/ Owners: piotrp Branches: f19 f20 f21 InitialCC: piotrp Git done (by process-git-requests). python-structlog-0.4.2-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-structlog-0.4.2-3.fc20 python-structlog-0.4.2-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-structlog-0.4.2-3.fc21 python-structlog-0.4.2-3.fc20 has been pushed to the Fedora 20 testing repository. python-structlog-0.4.2-3.fc21 has been pushed to the Fedora 21 stable repository. python-structlog-0.4.2-3.fc20 has been pushed to the Fedora 20 stable repository. Package Change Request ====================== Package Name: python-structlog New Branches: el6 epel7 Owners: piotrp Git done (by process-git-requests). python-structlog-0.4.2-5.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/python-structlog-0.4.2-5.el7 python-structlog-0.4.2-5.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-structlog-0.4.2-5.el6 python-structlog-0.4.2-5.el6 has been pushed to the Fedora EPEL 6 stable repository. python-structlog-0.4.2-5.el7 has been pushed to the Fedora EPEL 7 stable repository. |