Spec URL: http://vps533.directvps.nl/python-pretend.spec SRPM URL: http://vps533.directvps.nl/python-pretend-1.0.8-1.fc20.src.rpm Description: Pretend is a library to make stubbing with Python easier. Fedora Account System Username: piotrp koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7916133 This is a dependency for check section for python-structlog http://koji.fedoraproject.org/koji/taskinfo?taskID=7916133 I need a sponsor, thnx!
1) The given spec file and spec file packaged in SRPM is not same, I guess its some whitespace issue. correct this by having same spec packaged in srpm. 2) Group tag is optional in fedora releases. You may want to remove it but not mandatory 3) you should add license tag for python3-pretend also. 4) Its a good practice to remove any upstream supplied egg-info files in %prep and have packaged the newly generated egg-info files. rm -rf *.egg-info Otherwise package looks fine.
Thanks for commenting. 1) Rebuilt package and reuploaded spec/srpm, should be ok now. (rpmlint has no warnings/errors) 2) Deleted group tag 3) Added license tag to python3-pretend 4) I think the package did only install the new egg-info but I added the rm -rf *.egg-info to %prep to be sure. srpm + spec uploaded to the same url (did not increase package version number)
okay. This package looks good for final package review. Can you do more package reviews (3 to 5) where you actually find issues in packaging and suggest solutions on how to fix it. I will sponsor you then :)
Review: + is OK - is Needs Work + Package built successful in mock (f22 x86_64) + rpmlint on generated rpms gave output 3 packages and 0 specfiles checked; 0 errors, 0 warnings. + Source verified with upstream as sha256sum srpm tarball: 930f2c1e18503e8f8c403abe2e02166c4a881941745147e712cdd4f49f3fb964 upstream tarball: 930f2c1e18503e8f8c403abe2e02166c4a881941745147e712cdd4f49f3fb964 + License is BSD and included in LICENSE.rst file + follow python packaging guidelines + rest also looks as per packaging guidelines. APPROVED this package. Note as you know you are not sponsored yet so you may want to wait here before going to add SCM git request for this package.
Great!!! I've started a couple more reviews, see: https://bugzilla.redhat.com/show_bug.cgi?id=1141494 https://bugzilla.redhat.com/show_bug.cgi?id=1146929 https://bugzilla.redhat.com/show_bug.cgi?id=1146928 https://bugzilla.redhat.com/show_bug.cgi?id=1147681 https://bugzilla.redhat.com/show_bug.cgi?id=1156409 https://bugzilla.redhat.com/show_bug.cgi?id=1155403 https://bugzilla.redhat.com/show_bug.cgi?id=1155495
That's nice!! I have sponsored you now in packager group :) you can follow the package review process as given in http://fedoraproject.org/wiki/New_package_process_for_existing_contributors from step 7 here. Keep reviewing packages as we are short of package reviewers in Fedora. See list for packages to review http://fedoraproject.org/PackageReviewStatus/NEW.html
New Package SCM Request ======================= Package Name: python-pretend Short Description: A library for stubbing in Python Upstream URL: https://github.com/alex/pretend Owners: piotrp Branches: f19 f20 f21 InitialCC: piotrp
Git done (by process-git-requests).
python-pretend-1.0.8-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-pretend-1.0.8-1.fc21
python-pretend-1.0.8-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-pretend-1.0.8-1.fc20
python-pretend-1.0.8-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-pretend-1.0.8-1.fc19
python-pretend-1.0.8-1.fc20 has been pushed to the Fedora 20 stable repository.
python-pretend-1.0.8-1.fc19 has been pushed to the Fedora 19 stable repository.
python-pretend-1.0.8-1.fc21 has been pushed to the Fedora 21 stable repository.
Package Change Request ====================== Package Name: python-pretend New Branches: el6 epel7 Owners: piotrp https://bugzilla.redhat.com/show_bug.cgi?id=1166900
python-pretend-1.0.8-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/python-pretend-1.0.8-2.el7
python-pretend-1.0.8-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-pretend-1.0.8-2.el6
python-pretend-1.0.8-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
python-pretend-1.0.8-2.el7 has been pushed to the Fedora EPEL 7 stable repository.