Bug 1154405

Summary:	Review Request: perl-Struct-Dumb - Make simple lightweight record-like structures
Product:	[Fedora] Fedora	Reporter:	Emmanuel Seyman <emmanuel>
Component:	Package Review	Assignee:	Petr Šabata <psabata>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, psabata
Target Milestone:	---	Flags:	psabata: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-10-29 08:37:42 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Emmanuel Seyman 2014-10-19 13:47:52 UTC

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Struct-Dumb/perl-Struct-Dumb.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Struct-Dumb/perl-Struct-Dumb-0.03-1.fc20.src.rpm
Description:
Struct::Dumb creates record-like structure types, similar to the struct
keyword in C, C++ or C#, or Record in Pascal. An invocation of this module
will create a construction function which returns new object references
with the given field values. These references all respond to lvalue methods
that access or modify the values stored.

Fedora Account System Username: eseyman

Comment 1 Petr Šabata 2014-10-20 14:03:26 UTC

Missing BR: perl
Useless BR: ExtUtils::MakeMaker

%{?perl_default_filter} isn't necessary.

The rest is fine.

Comment 2 Emmanuel Seyman 2014-10-20 23:15:26 UTC

(In reply to Petr Šabata from comment #1)
>
> Missing BR: perl
> Useless BR: ExtUtils::MakeMaker

Done.

> %{?perl_default_filter} isn't necessary.

I'ld rather keep it.

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Struct-Dumb/perl-Struct-Dumb.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Struct-Dumb/perl-Struct-Dumb-0.03-2.fc20.src.rpm

Comment 3 Petr Šabata 2014-10-27 12:40:25 UTC

(In reply to Emmanuel Seyman from comment #2)
> (In reply to Petr Šabata from comment #1)
> >
> > Missing BR: perl
> > Useless BR: ExtUtils::MakeMaker
> 
> Done.

Ack.

> > %{?perl_default_filter} isn't necessary.
> 
> I'ld rather keep it.

I don't see the reason for that but it's not breaking anything.

> Spec URL:
> http://people.parinux.org/~seyman/fedora/perl-Struct-Dumb/perl-Struct-Dumb.
> spec
> SRPM URL:
> http://people.parinux.org/~seyman/fedora/perl-Struct-Dumb/perl-Struct-Dumb-0.
> 03-2.fc20.src.rpm

Approved.

Comment 4 Emmanuel Seyman 2014-10-27 13:15:59 UTC

Thanks, Petr. Requesting SCM.

New Package SCM Request
=======================
Package Name: perl-Struct-Dumb
Short Description: Make simple lightweight record-like structures
Upstream URL: http://search.cpan.org/dist/Struct-Dumb/
Owners: eseyman
Branches: f20 f21
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2014-10-28 12:18:39 UTC

Git done (by process-git-requests).

Comment 6 Emmanuel Seyman 2014-10-29 08:37:42 UTC

Package imported, builds completed, updates issued.
Thank you for the repo, Jon.