Bug 1154405 - Review Request: perl-Struct-Dumb - Make simple lightweight record-like structures
Summary: Review Request: perl-Struct-Dumb - Make simple lightweight record-like struct...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-10-19 13:47 UTC by Emmanuel Seyman
Modified: 2014-10-29 08:37 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-10-29 08:37:42 UTC
Type: ---
Embargoed:
psabata: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Emmanuel Seyman 2014-10-19 13:47:52 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Struct-Dumb/perl-Struct-Dumb.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Struct-Dumb/perl-Struct-Dumb-0.03-1.fc20.src.rpm
Description:
Struct::Dumb creates record-like structure types, similar to the struct
keyword in C, C++ or C#, or Record in Pascal. An invocation of this module
will create a construction function which returns new object references
with the given field values. These references all respond to lvalue methods
that access or modify the values stored.

Fedora Account System Username: eseyman

Comment 1 Petr Šabata 2014-10-20 14:03:26 UTC
Missing BR: perl
Useless BR: ExtUtils::MakeMaker

%{?perl_default_filter} isn't necessary.

The rest is fine.

Comment 2 Emmanuel Seyman 2014-10-20 23:15:26 UTC
(In reply to Petr Šabata from comment #1)
>
> Missing BR: perl
> Useless BR: ExtUtils::MakeMaker

Done.

> %{?perl_default_filter} isn't necessary.

I'ld rather keep it.

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Struct-Dumb/perl-Struct-Dumb.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Struct-Dumb/perl-Struct-Dumb-0.03-2.fc20.src.rpm

Comment 3 Petr Šabata 2014-10-27 12:40:25 UTC
(In reply to Emmanuel Seyman from comment #2)
> (In reply to Petr Šabata from comment #1)
> >
> > Missing BR: perl
> > Useless BR: ExtUtils::MakeMaker
> 
> Done.

Ack.

> > %{?perl_default_filter} isn't necessary.
> 
> I'ld rather keep it.

I don't see the reason for that but it's not breaking anything.

> Spec URL:
> http://people.parinux.org/~seyman/fedora/perl-Struct-Dumb/perl-Struct-Dumb.
> spec
> SRPM URL:
> http://people.parinux.org/~seyman/fedora/perl-Struct-Dumb/perl-Struct-Dumb-0.
> 03-2.fc20.src.rpm

Approved.

Comment 4 Emmanuel Seyman 2014-10-27 13:15:59 UTC
Thanks, Petr. Requesting SCM.

New Package SCM Request
=======================
Package Name: perl-Struct-Dumb
Short Description: Make simple lightweight record-like structures
Upstream URL: http://search.cpan.org/dist/Struct-Dumb/
Owners: eseyman
Branches: f20 f21
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2014-10-28 12:18:39 UTC
Git done (by process-git-requests).

Comment 6 Emmanuel Seyman 2014-10-29 08:37:42 UTC
Package imported, builds completed, updates issued.
Thank you for the repo, Jon.


Note You need to log in before you can comment on or make changes to this bug.