Bug 1154406

Summary:	Review Request: perl-Unicode-CaseFold - Unicode case-folding for case-insensitive lookups
Product:	[Fedora] Fedora	Reporter:	Emmanuel Seyman <emmanuel>
Component:	Package Review	Assignee:	Petr Šabata <psabata>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, psabata
Target Milestone:	---	Flags:	psabata: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-10-29 08:37:01 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Emmanuel Seyman 2014-10-19 13:49:31 UTC

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Unicode-CaseFold/perl-Unicode-CaseFold.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Unicode-CaseFold/perl-Unicode-CaseFold-1.00-1.fc20.src.rpm
Description:
This module provides Unicode case-folding for Perl. Case-folding is a tool
that allows a program to make case-insensitive string comparisons or do case-
insensitive lookups.

Fedora Account System Username: eseyman

Comment 1 Petr Šabata 2014-10-20 14:27:09 UTC

Missing perl BR.

I think you should provide perl(Unicode::CaseFoldPP).

XSLoader is used at build time.  BR it.

There's no need for the explicit Exporter and Scalar::Util runtime dependencies.

The rest is fine.

Comment 2 Emmanuel Seyman 2014-10-20 23:16:39 UTC

(In reply to Petr Šabata from comment #1)
>
> Missing perl BR.

Added.

> I think you should provide perl(Unicode::CaseFoldPP).

Indeed. Fixed.

> XSLoader is used at build time.  BR it.

Added.


> There's no need for the explicit Exporter and Scalar::Util runtime
> dependencies.

Removed.

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Unicode-CaseFold/perl-Unicode-CaseFold.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Unicode-CaseFold/perl-Unicode-CaseFold-1.00-2.fc20.src.rpm

Comment 3 Petr Šabata 2014-10-27 12:45:00 UTC

(In reply to Emmanuel Seyman from comment #2)
> (In reply to Petr Šabata from comment #1)
> > There's no need for the explicit Exporter and Scalar::Util runtime
> > dependencies.
> 
> Removed.

You also removed XSLoader.  This dependency won't get autodetected.  Please, put it back.

Comment 4 Emmanuel Seyman 2014-10-27 13:19:52 UTC

Sigh... Fixed.


Spec URL: http://people.parinux.org/~seyman/fedora/perl-Unicode-CaseFold/perl-Unicode-CaseFold.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Unicode-CaseFold/perl-Unicode-CaseFold-1.00-3.fc20.src.rpm

Comment 5 Petr Šabata 2014-10-27 15:09:44 UTC

Okay, all good now :)

Comment 6 Emmanuel Seyman 2014-10-27 15:43:02 UTC

Thanks, Petr.

New Package SCM Request
=======================
Package Name: perl-Unicode-CaseFold
Short Description: Unicode case-folding for case-insensitive lookups
Upstream URL: http://search.cpan.org/dist/Unicode-CaseFold/
Owners: eseyman
Branches: f20 f21
InitialCC: perl-sig

Comment 7 Gwyn Ciesla 2014-10-28 12:20:25 UTC

Git done (by process-git-requests).

Comment 8 Emmanuel Seyman 2014-10-29 08:37:01 UTC

Package imported, builds completed, updates issued.