Bug 1154406 - Review Request: perl-Unicode-CaseFold - Unicode case-folding for case-insensitive lookups
Summary: Review Request: perl-Unicode-CaseFold - Unicode case-folding for case-insensi...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-10-19 13:49 UTC by Emmanuel Seyman
Modified: 2014-10-29 08:37 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-10-29 08:37:01 UTC
Type: ---
Embargoed:
psabata: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Emmanuel Seyman 2014-10-19 13:49:31 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Unicode-CaseFold/perl-Unicode-CaseFold.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Unicode-CaseFold/perl-Unicode-CaseFold-1.00-1.fc20.src.rpm
Description:
This module provides Unicode case-folding for Perl. Case-folding is a tool
that allows a program to make case-insensitive string comparisons or do case-
insensitive lookups.

Fedora Account System Username: eseyman

Comment 1 Petr Šabata 2014-10-20 14:27:09 UTC
Missing perl BR.

I think you should provide perl(Unicode::CaseFoldPP).

XSLoader is used at build time.  BR it.

There's no need for the explicit Exporter and Scalar::Util runtime dependencies.

The rest is fine.

Comment 2 Emmanuel Seyman 2014-10-20 23:16:39 UTC
(In reply to Petr Šabata from comment #1)
>
> Missing perl BR.

Added.

> I think you should provide perl(Unicode::CaseFoldPP).

Indeed. Fixed.

> XSLoader is used at build time.  BR it.

Added.


> There's no need for the explicit Exporter and Scalar::Util runtime
> dependencies.

Removed.

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Unicode-CaseFold/perl-Unicode-CaseFold.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Unicode-CaseFold/perl-Unicode-CaseFold-1.00-2.fc20.src.rpm

Comment 3 Petr Šabata 2014-10-27 12:45:00 UTC
(In reply to Emmanuel Seyman from comment #2)
> (In reply to Petr Šabata from comment #1)
> > There's no need for the explicit Exporter and Scalar::Util runtime
> > dependencies.
> 
> Removed.

You also removed XSLoader.  This dependency won't get autodetected.  Please, put it back.

Comment 5 Petr Šabata 2014-10-27 15:09:44 UTC
Okay, all good now :)

Comment 6 Emmanuel Seyman 2014-10-27 15:43:02 UTC
Thanks, Petr.

New Package SCM Request
=======================
Package Name: perl-Unicode-CaseFold
Short Description: Unicode case-folding for case-insensitive lookups
Upstream URL: http://search.cpan.org/dist/Unicode-CaseFold/
Owners: eseyman
Branches: f20 f21
InitialCC: perl-sig

Comment 7 Gwyn Ciesla 2014-10-28 12:20:25 UTC
Git done (by process-git-requests).

Comment 8 Emmanuel Seyman 2014-10-29 08:37:01 UTC
Package imported, builds completed, updates issued.


Note You need to log in before you can comment on or make changes to this bug.