Bug 1155042

Summary:	[USS] : don't display the snapshots which are not activated
Product:	[Community] GlusterFS	Reporter:	Sachin Pandit <spandit>
Component:	snapshot	Assignee:	Sachin Pandit <spandit>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	mainline	CC:	bugs, nsathyan, vbellur
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	USS
Fixed In Version:	glusterfs-3.7.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1160280 1170548 (view as bug list)		Environment:
Last Closed:	2015-05-14 17:28:03 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1160280, 1170548

Description Sachin Pandit 2014-10-21 10:07:10 UTC

Description of problem:
It is better not to display the snapshots if they are not activated.
Displaying the snapshots might confuse the user as he might this that
the displayed snapshot might be in usable state.


Version-Release number of selected component (if applicable):


How reproducible:
1/1

Steps to Reproduce:
1. create a volume
2. mount the volume
3. enable uss
3. go to <mount-path>/.snaps
4. create a snapshot (snap1)
5. check if snapshot snap1 is present
6. deactivate the snapshot snap1
and you can see the snap1 is still present

Actual results:
deactivated snapshot is still being displayed

Expected results:
don't display the deactivated snapshots.


Additional info:

Comment 1 Anand Avati 2014-10-21 10:09:44 UTC

REVIEW: http://review.gluster.org/8958 (USS : fetch only the activated snapshots) posted (#1) for review on master by Sachin Pandit (spandit)

Comment 2 Anand Avati 2014-11-07 06:09:10 UTC

REVIEW: http://review.gluster.org/8958 (USS : Display only the activated snapshots) posted (#2) for review on master by Sachin Pandit (spandit)

Comment 3 Anand Avati 2014-11-07 06:13:02 UTC

REVIEW: http://review.gluster.org/8958 (USS : Display only the activated snapshots) posted (#3) for review on master by Sachin Pandit (spandit)

Comment 4 Anand Avati 2014-11-07 10:35:48 UTC

REVIEW: http://review.gluster.org/8958 (USS : Display only the activated snapshots) posted (#4) for review on master by Sachin Pandit (spandit)

Comment 5 Anand Avati 2014-11-10 06:03:47 UTC

REVIEW: http://review.gluster.org/8958 (USS : Display only the activated snapshots) posted (#5) for review on master by Sachin Pandit (spandit)

Comment 6 Anand Avati 2014-11-10 08:39:58 UTC

REVIEW: http://review.gluster.org/8958 (USS : Display only the activated snapshots) posted (#6) for review on master by Sachin Pandit (spandit)

Comment 7 Anand Avati 2014-11-11 05:35:38 UTC

REVIEW: http://review.gluster.org/8958 (USS : Display only the activated snapshots) posted (#7) for review on master by Sachin Pandit (spandit)

Comment 8 Anand Avati 2014-11-12 11:20:14 UTC

COMMIT: http://review.gluster.org/8958 committed in master by Krishnan Parthasarathi (kparthas) 
------
commit 70b0c7b725408fc82969e15dcf67cd352b0fb68b
Author: Sachin Pandit <spandit>
Date:   Tue Oct 21 07:57:22 2014 +0530

    USS : Display only the activated snapshots
    
    Instead of displaying all the snapshots in the uss world,
    it is better if we display only the activated snapshots.
    
    Change-Id: I70d3ec212b62ec15956ae3e826bc4201d8dedd17
    BUG: 1155042
    Signed-off-by: Sachin Pandit <spandit>
    Reviewed-on: http://review.gluster.org/8958
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Avra Sengupta <asengupt>
    Reviewed-by: Rajesh Joseph <rjoseph>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Krishnan Parthasarathi <kparthas>

Comment 9 Anand Avati 2014-11-13 05:38:33 UTC

REVIEW: http://review.gluster.org/9113 (test/uss : activate the snapshot after creating.) posted (#1) for review on master by Sachin Pandit (spandit)

Comment 10 Anand Avati 2014-11-13 05:38:58 UTC

REVIEW: http://review.gluster.org/9113 (test/uss : activate the snapshot after creating.) posted (#2) for review on master by Sachin Pandit (spandit)

Comment 11 Anand Avati 2014-11-13 05:47:29 UTC

REVIEW: http://review.gluster.org/9113 (test/uss : activate the snapshot after creating.) posted (#3) for review on master by Sachin Pandit (spandit)

Comment 12 Anand Avati 2014-11-13 09:19:10 UTC

COMMIT: http://review.gluster.org/9113 committed in master by Kaushal M (kaushal) 
------
commit 75474f148daada475c235d0acaf345acad4ba9f3
Author: Sachin Pandit <spandit>
Date:   Thu Nov 13 03:57:57 2014 +0530

    test/uss : activate the snapshot after creating.
    
    Till now we were activating the snapshot along with the snapshot create.
    But one of the recent patches has changed that behavior. Now we have
    to explicitly issue activate-on-create using snapshot config if we
    want snapshot to be activated during snapshot create.
    
    Till patch fixes the regression failure which is seen lately.
    
    Change-Id: Ic53b16e22569e521bd70dd3bfa7154a0424151ce
    BUG: 1155042
    Signed-off-by: Sachin Pandit <spandit>
    Reviewed-on: http://review.gluster.org/9113
    Reviewed-by: Rajesh Joseph <rjoseph>
    Reviewed-by: Meghana M <mmadhusu>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaushal M <kaushal>

Comment 13 Niels de Vos 2015-05-14 17:28:03 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 14 Niels de Vos 2015-05-14 17:35:39 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 15 Niels de Vos 2015-05-14 17:38:01 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 16 Niels de Vos 2015-05-14 17:44:09 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user