Bug 1170548 - [USS] : don't display the snapshots which are not activated
Summary: [USS] : don't display the snapshots which are not activated
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: snapshot
Version: 3.6.1
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
Assignee: Raghavendra Bhat
QA Contact:
URL:
Whiteboard: USS
Depends On: 1155042
Blocks: glusterfs-3.6.2
TreeView+ depends on / blocked
 
Reported: 2014-12-04 10:09 UTC by Raghavendra Bhat
Modified: 2015-12-01 16:45 UTC (History)
4 users (show)

Fixed In Version: glusterfs-3.6.2
Doc Type: Bug Fix
Doc Text:
Clone Of: 1155042
Environment:
Last Closed: 2015-02-11 09:11:51 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Raghavendra Bhat 2014-12-04 10:09:27 UTC
+++ This bug was initially created as a clone of Bug #1155042 +++

Description of problem:
It is better not to display the snapshots if they are not activated.
Displaying the snapshots might confuse the user as he might this that
the displayed snapshot might be in usable state.


Version-Release number of selected component (if applicable):


How reproducible:
1/1

Steps to Reproduce:
1. create a volume
2. mount the volume
3. enable uss
3. go to <mount-path>/.snaps
4. create a snapshot (snap1)
5. check if snapshot snap1 is present
6. deactivate the snapshot snap1
and you can see the snap1 is still present

Actual results:
deactivated snapshot is still being displayed

Expected results:
don't display the deactivated snapshots.


Additional info:

--- Additional comment from Anand Avati on 2014-10-21 06:09:44 EDT ---

REVIEW: http://review.gluster.org/8958 (USS : fetch only the activated snapshots) posted (#1) for review on master by Sachin Pandit (spandit)

--- Additional comment from Anand Avati on 2014-11-07 01:09:10 EST ---

REVIEW: http://review.gluster.org/8958 (USS : Display only the activated snapshots) posted (#2) for review on master by Sachin Pandit (spandit)

--- Additional comment from Anand Avati on 2014-11-07 01:13:02 EST ---

REVIEW: http://review.gluster.org/8958 (USS : Display only the activated snapshots) posted (#3) for review on master by Sachin Pandit (spandit)

--- Additional comment from Anand Avati on 2014-11-07 05:35:48 EST ---

REVIEW: http://review.gluster.org/8958 (USS : Display only the activated snapshots) posted (#4) for review on master by Sachin Pandit (spandit)

--- Additional comment from Anand Avati on 2014-11-10 01:03:47 EST ---

REVIEW: http://review.gluster.org/8958 (USS : Display only the activated snapshots) posted (#5) for review on master by Sachin Pandit (spandit)

--- Additional comment from Anand Avati on 2014-11-10 03:39:58 EST ---

REVIEW: http://review.gluster.org/8958 (USS : Display only the activated snapshots) posted (#6) for review on master by Sachin Pandit (spandit)

--- Additional comment from Anand Avati on 2014-11-11 00:35:38 EST ---

REVIEW: http://review.gluster.org/8958 (USS : Display only the activated snapshots) posted (#7) for review on master by Sachin Pandit (spandit)

--- Additional comment from Anand Avati on 2014-11-12 06:20:14 EST ---

COMMIT: http://review.gluster.org/8958 committed in master by Krishnan Parthasarathi (kparthas) 
------
commit 70b0c7b725408fc82969e15dcf67cd352b0fb68b
Author: Sachin Pandit <spandit>
Date:   Tue Oct 21 07:57:22 2014 +0530

    USS : Display only the activated snapshots
    
    Instead of displaying all the snapshots in the uss world,
    it is better if we display only the activated snapshots.
    
    Change-Id: I70d3ec212b62ec15956ae3e826bc4201d8dedd17
    BUG: 1155042
    Signed-off-by: Sachin Pandit <spandit>
    Reviewed-on: http://review.gluster.org/8958
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Avra Sengupta <asengupt>
    Reviewed-by: Rajesh Joseph <rjoseph>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Krishnan Parthasarathi <kparthas>

--- Additional comment from Anand Avati on 2014-11-13 00:38:33 EST ---

REVIEW: http://review.gluster.org/9113 (test/uss : activate the snapshot after creating.) posted (#1) for review on master by Sachin Pandit (spandit)

--- Additional comment from Anand Avati on 2014-11-13 00:38:58 EST ---

REVIEW: http://review.gluster.org/9113 (test/uss : activate the snapshot after creating.) posted (#2) for review on master by Sachin Pandit (spandit)

--- Additional comment from Anand Avati on 2014-11-13 00:47:29 EST ---

REVIEW: http://review.gluster.org/9113 (test/uss : activate the snapshot after creating.) posted (#3) for review on master by Sachin Pandit (spandit)

--- Additional comment from Anand Avati on 2014-11-13 04:19:10 EST ---

COMMIT: http://review.gluster.org/9113 committed in master by Kaushal M (kaushal) 
------
commit 75474f148daada475c235d0acaf345acad4ba9f3
Author: Sachin Pandit <spandit>
Date:   Thu Nov 13 03:57:57 2014 +0530

    test/uss : activate the snapshot after creating.
    
    Till now we were activating the snapshot along with the snapshot create.
    But one of the recent patches has changed that behavior. Now we have
    to explicitly issue activate-on-create using snapshot config if we
    want snapshot to be activated during snapshot create.
    
    Till patch fixes the regression failure which is seen lately.
    
    Change-Id: Ic53b16e22569e521bd70dd3bfa7154a0424151ce
    BUG: 1155042
    Signed-off-by: Sachin Pandit <spandit>
    Reviewed-on: http://review.gluster.org/9113
    Reviewed-by: Rajesh Joseph <rjoseph>
    Reviewed-by: Meghana M <mmadhusu>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaushal M <kaushal>

Comment 1 Anand Avati 2014-12-04 10:22:29 UTC
REVIEW: http://review.gluster.org/9235 (USS : Display only the activated snapshots) posted (#1) for review on release-3.6 by Raghavendra Bhat (raghavendra)

Comment 2 Anand Avati 2014-12-04 12:51:43 UTC
REVIEW: http://review.gluster.org/9235 (USS : Display only the activated snapshots) posted (#2) for review on release-3.6 by Raghavendra Bhat (raghavendra)

Comment 3 Anand Avati 2014-12-05 06:24:04 UTC
REVIEW: http://review.gluster.org/9242 (USS : Display only the activated snapshots) posted (#1) for review on release-3.6 by Sachin Pandit (spandit)

Comment 4 Anand Avati 2014-12-05 06:24:07 UTC
REVIEW: http://review.gluster.org/9243 (test/uss : activate the snapshot after creating.) posted (#1) for review on release-3.6 by Sachin Pandit (spandit)

Comment 5 Anand Avati 2014-12-07 10:44:39 UTC
REVIEW: http://review.gluster.org/9242 (USS : Display only the activated snapshots) posted (#2) for review on release-3.6 by Sachin Pandit (spandit)

Comment 6 Anand Avati 2014-12-18 15:06:35 UTC
REVIEW: http://review.gluster.org/9242 (USS : Display only the activated snapshots) posted (#3) for review on release-3.6 by Sachin Pandit (spandit)

Comment 7 Anand Avati 2014-12-18 17:20:47 UTC
REVIEW: http://review.gluster.org/9242 (USS : Display only the activated snapshots.) posted (#4) for review on release-3.6 by Sachin Pandit (spandit)

Comment 8 Anand Avati 2014-12-19 06:53:08 UTC
COMMIT: http://review.gluster.org/9242 committed in release-3.6 by Raghavendra Bhat (raghavendra) 
------
commit 859cdebc2d2b425fd76f46d598ad59933396b279
Author: Sachin Pandit <spandit>
Date:   Tue Oct 21 07:57:22 2014 +0530

    USS : Display only the activated snapshots.
    
    Instead of displaying all the snapshots in the uss world,
    it is better if we display only the activated snapshots.
    
    Change-Id: I70d3ec212b62ec15956ae3e826bc4201d8dedd17
    BUG: 1170548
    Signed-off-by: Sachin Pandit <spandit>
    Reviewed-on: http://review.gluster.org/8958
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Avra Sengupta <asengupt>
    Reviewed-by: Rajesh Joseph <rjoseph>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Krishnan Parthasarathi <kparthas>
    Signed-off-by: Sachin Pandit <spandit>
    Reviewed-on: http://review.gluster.org/9242
    Reviewed-by: Vijaikumar Mallikarjuna <vmallika>
    Reviewed-by: Raghavendra Bhat <raghavendra>

Comment 9 Raghavendra Bhat 2015-02-11 09:11:51 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.2, please reopen this bug report.

glusterfs-3.6.2 has been announced on the Gluster Developers mailinglist [1], packages for several distributions should already be or become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

The fix for this bug likely to be included in all future GlusterFS releases i.e. release > 3.6.2.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/5978
[2] http://news.gmane.org/gmane.comp.file-systems.gluster.user
[3] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6137


Note You need to log in before you can comment on or make changes to this bug.