Bug 1155234

Summary: [RFE] Quote strings in error from rlAsserEqual
Product: [Fedora] Fedora Reporter: Alois Mahdal <amahdal>
Component: beakerlibAssignee: Dalibor Pospíšil <dapospis>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 20CC: dapospis, pmuller, psplicha
Target Milestone: ---Keywords: Patch
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: beakerlib-1.10-1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-12-12 14:48:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1136360, 1136362    
Attachments:
Description Flags
Patch proposal none

Description Alois Mahdal 2014-10-21 16:04:36 UTC 
Description of problem:

Message from `rlAsserEqual()` may be confusing with some values that seem to fit into sentence.  For example, when comparing output from file(1), I got:

    :: [   FAIL   ] :: Data is present in lsvpd output (Assert: ASCII text,
    with very long lines should equal data)

which can be confusing if reader is not familliar with formatting of the message.

Simply quoting the message improves this:

    :: [   FAIL   ] :: Data is present in lsvpd output (Assert: 'ASCII text,
    with very long lines' should equal 'data')


Version-Release number of selected component (if applicable):
beakerlib-1.9-3.fc20.noarch but also current master (f7e3b48)
Comment 1 Alois Mahdal 2014-10-21 16:08:25 UTC 
Created attachment 949044 [details]
Patch proposal

In theory we could want another quotes (double quotes or even some paranoid type) but IMHO single quotes are enough in most cases, and I like the implied semantic of "constant" (not sure where I've picked this up ;)).
Comment 2 Dalibor Pospíšil 2014-10-22 10:50:17 UTC 
Thanks for patch.

fixed by https://git.fedorahosted.org/cgit/beakerlib.git/commit/?id=0b2772ee40d0146b8d90557df85e9c8500f67439