Bug 1155234 - [RFE] Quote strings in error from rlAsserEqual
Summary: [RFE] Quote strings in error from rlAsserEqual
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: beakerlib
Version: 20
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dalibor Pospíšil
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: Fedora-beakerlib-1.10 1136362
TreeView+ depends on / blocked
 
Reported: 2014-10-21 16:04 UTC by Alois Mahdal
Modified: 2015-04-28 17:21 UTC (History)
3 users (show)

Fixed In Version: beakerlib-1.10-1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-12-12 14:48:00 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch proposal (808 bytes, patch)
2014-10-21 16:08 UTC, Alois Mahdal
no flags Details | Diff

Description Alois Mahdal 2014-10-21 16:04:36 UTC
Description of problem:

Message from `rlAsserEqual()` may be confusing with some values that seem to fit into sentence.  For example, when comparing output from file(1), I got:

    :: [   FAIL   ] :: Data is present in lsvpd output (Assert: ASCII text,
    with very long lines should equal data)

which can be confusing if reader is not familliar with formatting of the message.

Simply quoting the message improves this:

    :: [   FAIL   ] :: Data is present in lsvpd output (Assert: 'ASCII text,
    with very long lines' should equal 'data')


Version-Release number of selected component (if applicable):
beakerlib-1.9-3.fc20.noarch but also current master (f7e3b48)

Comment 1 Alois Mahdal 2014-10-21 16:08:25 UTC
Created attachment 949044 [details]
Patch proposal

In theory we could want another quotes (double quotes or even some paranoid type) but IMHO single quotes are enough in most cases, and I like the implied semantic of "constant" (not sure where I've picked this up ;)).

Comment 2 Dalibor Pospíšil 2014-10-22 10:50:17 UTC
Thanks for patch.

fixed by https://git.fedorahosted.org/cgit/beakerlib.git/commit/?id=0b2772ee40d0146b8d90557df85e9c8500f67439


Note You need to log in before you can comment on or make changes to this bug.