Bug 1156298
| Summary: | Remove files in package libguestfs-bash-completion, these files are bash completion files, some of the virt tool completion are already implement in another file, so can remove its completion file | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Lingfei Kong <lkong> |
| Component: | libguestfs | Assignee: | Richard W.M. Jones <rjones> |
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 7.1 | CC: | leiwang, linl, mbooth, ptoscano, wshi, xchen |
| Target Milestone: | rc | Keywords: | Improvement |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | libguestfs-1.31.7-2.el7.x86_64 | Doc Type: | Enhancement |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-11-03 17:47:05 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1218766 | ||
| Bug Blocks: | 1288337, 1301891 | ||
|
Description
Lingfei Kong
2014-10-24 06:42:40 UTC
The issue is these are supposed to be symbolic links, not regular files (not that it makes much difference, but I guess it saves a tiny amount of space). In the source: $ ll total 140 -rw-rw-r--. 1 rjones rjones 2192 Aug 7 16:16 guestfish -rw-rw-r--. 1 rjones rjones 1973 Aug 7 16:16 guestmount -rw-rw-r--. 1 rjones rjones 51641 Oct 23 16:10 Makefile -rw-rw-r--. 1 rjones rjones 1734 Sep 1 22:17 Makefile.am -rw-rw-r--. 1 rjones rjones 60381 Oct 23 16:09 Makefile.in -rw-rw-r--. 1 rjones rjones 152 Aug 7 16:16 README -rw-rw-r--. 1 rjones rjones 2902 Oct 15 15:40 virt-alignment-scan lrwxrwxrwx. 1 rjones rjones 11 Mar 23 2014 virt-builder -> virt-resize lrwxrwxrwx. 1 rjones rjones 19 Mar 23 2014 virt-cat -> virt-alignment-scan lrwxrwxrwx. 1 rjones rjones 19 Mar 23 2014 virt-df -> virt-alignment-scan lrwxrwxrwx. 1 rjones rjones 19 Mar 23 2014 virt-edit -> virt-alignment-scan lrwxrwxrwx. 1 rjones rjones 19 Mar 23 2014 virt-filesystems -> virt-alignment-scan lrwxrwxrwx. 1 rjones rjones 19 Mar 23 2014 virt-format -> virt-alignment-scan lrwxrwxrwx. 1 rjones rjones 19 Mar 23 2014 virt-inspector -> virt-alignment-scan lrwxrwxrwx. 1 rjones rjones 19 Jun 14 11:02 virt-log -> virt-alignment-scan lrwxrwxrwx. 1 rjones rjones 19 Mar 23 2014 virt-ls -> virt-alignment-scan -rw-rw-r--. 1 rjones rjones 1978 Aug 7 16:16 virt-rescue -rw-rw-r--. 1 rjones rjones 1589 Aug 7 16:16 virt-resize lrwxrwxrwx. 1 rjones rjones 11 Mar 23 2014 virt-sparsify -> virt-resize lrwxrwxrwx. 1 rjones rjones 19 Mar 23 2014 virt-sysprep -> virt-alignment-scan The symbolic links have to be there because of new bash-completion demand loading, see: https://lists.fedoraproject.org/pipermail/devel/2013-March/thread.html#180508 (I can't find any better documentation about it now) So that didn't in fact use symlinks, but for reasons I understand (the tarball has to be rebuilt). Moving to 7.2 as this is purely cosmetic. Seems to be fixed now: libguestfs-bash-completion-1.31.7-2.el7.noarch $ for f in `rpm -ql libguestfs-bash-completion`; do if [ ! -d $f ]; then ls -l $f; fi; done -rw-r--r--. 1 root root 2451 Sep 22 05:18 /usr/share/bash-completion/completions/guestfish -rw-r--r--. 1 root root 2234 Sep 22 05:18 /usr/share/bash-completion/completions/guestmount -rw-r--r--. 1 root root 3018 Sep 22 05:18 /usr/share/bash-completion/completions/virt-alignment-scan lrwxrwxrwx. 1 root root 11 Sep 22 05:57 /usr/share/bash-completion/completions/virt-builder -> virt-resize lrwxrwxrwx. 1 root root 19 Sep 22 05:57 /usr/share/bash-completion/completions/virt-cat -> virt-alignment-scan lrwxrwxrwx. 1 root root 19 Sep 22 05:57 /usr/share/bash-completion/completions/virt-df -> virt-alignment-scan lrwxrwxrwx. 1 root root 19 Sep 22 05:57 /usr/share/bash-completion/completions/virt-edit -> virt-alignment-scan lrwxrwxrwx. 1 root root 19 Sep 22 05:57 /usr/share/bash-completion/completions/virt-filesystems -> virt-alignment-scan lrwxrwxrwx. 1 root root 19 Sep 22 05:57 /usr/share/bash-completion/completions/virt-format -> virt-alignment-scan lrwxrwxrwx. 1 root root 19 Sep 22 05:57 /usr/share/bash-completion/completions/virt-inspector -> virt-alignment-scan lrwxrwxrwx. 1 root root 19 Sep 22 05:57 /usr/share/bash-completion/completions/virt-log -> virt-alignment-scan lrwxrwxrwx. 1 root root 19 Sep 22 05:57 /usr/share/bash-completion/completions/virt-ls -> virt-alignment-scan -rw-r--r--. 1 root root 2241 Sep 22 05:18 /usr/share/bash-completion/completions/virt-rescue -rw-r--r--. 1 root root 2363 Sep 22 05:18 /usr/share/bash-completion/completions/virt-resize lrwxrwxrwx. 1 root root 11 Sep 22 05:57 /usr/share/bash-completion/completions/virt-sparsify -> virt-resize lrwxrwxrwx. 1 root root 19 Sep 22 05:57 /usr/share/bash-completion/completions/virt-sysprep -> virt-alignment-scan -rw-r--r--. 1 root root 2089 Sep 22 05:18 /usr/share/bash-completion/completions/virt-v2v Verified with the packages: libguestfs-1.32.5-6.el7.x86_64 libguestfs-bash-completion-1.32.5-6.el7.noarch Verify steps: # for f in `rpm -ql libguestfs-bash-completion`; do if [ ! -d $f ]; then ls -l $f; fi; done -rw-r--r--. 1 root root 2451 Jun 24 01:30 /usr/share/bash-completion/completions/guestfish -rw-r--r--. 1 root root 2234 Jun 24 01:30 /usr/share/bash-completion/completions/guestmount -rw-r--r--. 1 root root 3018 Jun 24 01:30 /usr/share/bash-completion/completions/virt-alignment-scan lrwxrwxrwx. 1 root root 11 Jun 24 18:31 /usr/share/bash-completion/completions/virt-builder -> virt-resize lrwxrwxrwx. 1 root root 19 Jun 24 18:31 /usr/share/bash-completion/completions/virt-cat -> virt-alignment-scan lrwxrwxrwx. 1 root root 19 Jun 24 18:31 /usr/share/bash-completion/completions/virt-df -> virt-alignment-scan lrwxrwxrwx. 1 root root 19 Jun 24 18:31 /usr/share/bash-completion/completions/virt-edit -> virt-alignment-scan lrwxrwxrwx. 1 root root 19 Jun 24 18:31 /usr/share/bash-completion/completions/virt-filesystems -> virt-alignment-scan lrwxrwxrwx. 1 root root 19 Jun 24 18:31 /usr/share/bash-completion/completions/virt-format -> virt-alignment-scan lrwxrwxrwx. 1 root root 19 Jun 24 18:31 /usr/share/bash-completion/completions/virt-inspector -> virt-alignment-scan lrwxrwxrwx. 1 root root 19 Jun 24 18:31 /usr/share/bash-completion/completions/virt-log -> virt-alignment-scan lrwxrwxrwx. 1 root root 19 Jun 24 18:31 /usr/share/bash-completion/completions/virt-ls -> virt-alignment-scan -rw-r--r--. 1 root root 2241 Jun 24 01:30 /usr/share/bash-completion/completions/virt-rescue -rw-r--r--. 1 root root 2487 Jun 24 01:30 /usr/share/bash-completion/completions/virt-resize lrwxrwxrwx. 1 root root 11 Jun 24 18:31 /usr/share/bash-completion/completions/virt-sparsify -> virt-resize lrwxrwxrwx. 1 root root 19 Jun 24 18:31 /usr/share/bash-completion/completions/virt-sysprep -> virt-alignment-scan -rw-r--r--. 1 root root 2089 Jun 24 01:30 /usr/share/bash-completion/completions/virt-v2v Seems fine now, all keep one file. So verified. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHSA-2016-2576.html |