Bug 1156661

Summary:	Kernel crash when unmounting Ext4 filesystem
Product:	Red Hat Enterprise Linux 6	Reporter:	wshilong
Component:	kernel	Assignee:	Eric Sandeen <esandeen>
kernel sub component:	ext*	QA Contact:	Murphy Zhou <xzhou>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	high
Priority:	unspecified	CC:	bob.glossman, ctatman, dbayly, eguan, esandeen, jamorgan, ovasik, peter.a.jones, wshilong, xzhou
Version:	6.6
Target Milestone:	rc
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	kernel-2.6.32-527.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-07-22 08:29:03 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1128951

Description wshilong 2014-10-25 01:12:54 UTC

Description of problem:

When using Ext4 filesystem, filesystem hits something bad which makes filesystem
force to be readonly..But in ext4_delete_inode() we don't cleanup orphan inode from
list properly..which will make us crash when unmounting..

See following message:
<2>LDISKFS-fs error (device dm-2): __ldiskfs_ext_check_block: bad header/extent in inode #659: invalid magic - magic e000, entries 456, max 0(0), depth 51424(0)
<3>Aborting journal on device dm-2-8.
<2>LDISKFS-fs error (device dm-2) in ldiskfs_free_blocks: Journal has aborted
<2>LDISKFS-fs error (device dm-2) in ldiskfs_free_blocks: Journal has aborted
<2>LDISKFS-fs (dm-2): Remounting filesystem read-only
<2>LDISKFS-fs error (device dm-2) in ldiskfs_free_blocks: Journal has aborted
<2>LDISKFS-fs error (device dm-2) in ldiskfs_ext_remove_space: Journal has aborted
<2>LDISKFS-fs error (device dm-2) in ldiskfs_reserve_inode_write: Journal has aborted
<2>LDISKFS-fs error (device dm-2) in ldiskfs_ext_truncate: Journal has aborted
<4>LDISKFS-fs warning (device dm-2): ldiskfs_delete_inode: couldn't extend journal (err -5)
<3>LDISKFS-fs (dm-2): Inode 280 (ffff8803a9ecb6d8): orphan list check failed!

Here ldiskfs is ext4, when unmounting, it will hit ASSERTION which will crash kernel,
original problem we hit is coming from Lustre, see this reports:
https://jira.hpdd.intel.com/browse/LU-5771?filter=-2

Version-Release number of selected component (if applicable):
This problem exists for rhel6 series..

So following upstream commit fixed kernel crash problem, could you please merge them into rhel6 kernel?

commit 4538821993f4486c76090dfb377c60c0a0e71ba3
Author: Theodore Ts'o <tytso>
Date:   Thu Jul 29 15:06:10 2010 -0400

    ext4: drop inode from orphan list if ext4_delete_inode() fails
    
    There were some error paths in ext4_delete_inode() which was not
    dropping the inode from the orphan list.  This could lead to a BUG_ON
    on umount when the orphan list is discovered to be non-empty.
    
    Signed-off-by: "Theodore Ts'o" <tytso>

Comment 2 Ondrej Vasik 2014-10-25 19:46:43 UTC

filesystem component has nothing to do with ext4 filesystem (it just handles basic directory layout). You want kernel component and File systems subcomponent. Reassigning...

Comment 3 Eric Sandeen 2014-10-25 19:49:43 UTC

Looks reasonable, thanks for the report.

Comment 5 Murphy Zhou 2014-10-28 01:26:11 UTC

(In reply to wshilong from comment #0)
> Description of problem:
> 
> original problem we hit is coming from Lustre, see this reports:
> https://jira.hpdd.intel.com/browse/LU-5771?filter=-2

This requires an account login. It will be great that if there is a reproducer or any particular procedures. Thanks very much!

Comment 6 wshilong 2014-10-28 04:12:46 UTC

(In reply to xzhou from comment #5)
> (In reply to wshilong from comment #0)
> > Description of problem:
> > 
> > original problem we hit is coming from Lustre, see this reports:
> > https://jira.hpdd.intel.com/browse/LU-5771?filter=-2
> 
> This requires an account login. It will be great that if there is a
> reproducer or any particular procedures. Thanks very much!

Hello xzhou,

Unluckily i don't have a simple reproducer to reproduce this problem, however this problem did happen in our environment.

Previously i confirmed this problem and patch by hacking codes to force to expected error path, normally this problem did not happen, but it could in some error cases.

Best regards,
Wang Shilong

Comment 7 RHEL Program Management 2014-11-10 23:09:49 UTC

This request was evaluated by Red Hat Product Management for
inclusion in a Red Hat Enterprise Linux release.  Product
Management has requested further review of this request by
Red Hat Engineering, for potential inclusion in a Red Hat
Enterprise Linux release for currently deployed products.
This request is not yet committed for inclusion in a release.

Comment 8 Rafael Aquini 2015-01-30 17:11:21 UTC

Patch(es) available on kernel-2.6.32-527.el6

Comment 13 errata-xmlrpc 2015-07-22 08:29:03 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-1272.html