Bug 115719

Summary: undefined code + 2 * printf problems
Product: [Fedora] Fedora Reporter: d.binderman
Component: openoffice.orgAssignee: Dan Williams <dcbw>
Status: CLOSED UPSTREAM QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 1   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2004-02-15 17:17:23 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description d.binderman 2004-02-15 12:12:05 UTC
Description of problem:

I just tried to compile package openoffice.org-1.1.0-6 from Fedora.

The compiler said

1.

auedit.c:1245: warning: operation on `p' may be undefined

The source code is

    while (numSamples--)
        *p++ = (*p + *data++) / 2;

better source code would be

    while (numSamples--)
    {
        *p = (*p + *data++) / 2;
        ++p;
    }

2.

/usr/src/redhat/BUILD/oo_1.1_src/configmgr/source/treecache/cacheaccess.cxx:365:
warning: too many arguments for format

The source code is

    CFG_TRACE_INFO("CacheLoadingAccess: Adding component data  for
module '%s'",                   
OUSTRING2ASCII(_aComponentInstance.component().toString()),
                    _bIncludesDefaults ? "Data includes defaults." :
"Data does
not include defaults." );

One % specifier, two following parameters.

3.

/usr/src/redhat/BUILD/oo_1.1_src/configmgr/source/api2/providerimpl.cxx:290:
warning: too many arguments for format

The source code is

            CFG_TRACE_ERROR_NI("Provider bootstrapping: Caught an
exception trying to get 'Setup' data: ", OUSTRING2ASCII(e.Message));

Maybe add a %s specifier in the message ?




Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Dan Williams 2004-02-15 17:17:23 UTC
Upstreaming.  The NAS bug with *p won't get fixed though.  Thanks for the heads-up!  
See:

http://www.openoffice.org/issues/show_bug.cgi?id=25508