Bug 115719 - undefined code + 2 * printf problems
Summary: undefined code + 2 * printf problems
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: openoffice.org
Version: 1
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Dan Williams
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2004-02-15 12:12 UTC by d.binderman
Modified: 2007-11-30 22:10 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2004-02-15 17:17:23 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description d.binderman 2004-02-15 12:12:05 UTC
Description of problem:

I just tried to compile package openoffice.org-1.1.0-6 from Fedora.

The compiler said

1.

auedit.c:1245: warning: operation on `p' may be undefined

The source code is

    while (numSamples--)
        *p++ = (*p + *data++) / 2;

better source code would be

    while (numSamples--)
    {
        *p = (*p + *data++) / 2;
        ++p;
    }

2.

/usr/src/redhat/BUILD/oo_1.1_src/configmgr/source/treecache/cacheaccess.cxx:365:
warning: too many arguments for format

The source code is

    CFG_TRACE_INFO("CacheLoadingAccess: Adding component data  for
module '%s'",                   
OUSTRING2ASCII(_aComponentInstance.component().toString()),
                    _bIncludesDefaults ? "Data includes defaults." :
"Data does
not include defaults." );

One % specifier, two following parameters.

3.

/usr/src/redhat/BUILD/oo_1.1_src/configmgr/source/api2/providerimpl.cxx:290:
warning: too many arguments for format

The source code is

            CFG_TRACE_ERROR_NI("Provider bootstrapping: Caught an
exception trying to get 'Setup' data: ", OUSTRING2ASCII(e.Message));

Maybe add a %s specifier in the message ?




Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Dan Williams 2004-02-15 17:17:23 UTC
Upstreaming.  The NAS bug with *p won't get fixed though.  Thanks for the heads-up!  
See:

http://www.openoffice.org/issues/show_bug.cgi?id=25508


Note You need to log in before you can comment on or make changes to this bug.