Bug 1157374

Summary:	Hook script S31ganesha-reset.sh accounts for 100% CPU usage and doesn't terminate
Product:	[Community] GlusterFS	Reporter:	Meghana <mmadhusu>
Component:	cli	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	3.6.0	CC:	bugs, gluster-bugs, jclift, vagarwal
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.6.1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1155489	Environment:
Last Closed:	2014-11-10 15:14:27 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1155489
Bug Blocks:	1117822

Description Meghana 2014-10-27 06:46:09 UTC

+++ This bug was initially created as a clone of Bug #1155489 +++

Description of problem
S31ganesha-reset.sh hook script's CPU usage is seen to be 100%.
The script doesn't terminate by itself.

Version-Release number of selected component (if applicable):


How reproducible:
Always


Steps to Reproduce:
1. Execute gluster vol reset <volname> <option> <force> command
2. Check if the script is running and also check for its CPU usage
3.

Actual results:
The script that runs in the post phase of the reset command doesn't terminate.
It accounts for 100% CPU usage.

Expected results:
The script shouldn't do anything at all, when ganesha is not enabled. And also 
the script should terminate in less than a second.


Additional info:

--- Additional comment from Anand Avati on 2014-10-22 06:16:40 EDT ---

REVIEW: http://review.gluster.org/8966 (Hooks : Infinite while loop introduced by another change.) posted (#1) for review on master by Meghana M (mmadhusu)

--- Additional comment from Anand Avati on 2014-10-24 04:17:03 EDT ---

COMMIT: http://review.gluster.org/8966 committed in master by Vijay Bellur (vbellur) 
------
commit a7a8a7507ca938b23d20a52931fa034cfaaa29f8
Author: Meghana Madhusudhan <mmadhusu>
Date:   Tue Oct 21 19:50:29 2014 +0530

    Hooks : Infinite while loop introduced by another change.
    
    A change made to all the hook scripts introduced an
    infinite while loop in the script S31ganesha-reset.sh.
    It resulted in 100% CPU usage by this script.
    
    Change-Id: If62d8f0e065c6e6511363b8b26eae433f59bc5c3
    BUG: 1155489
    Signed-off-by: Meghana Madhusudhan <mmadhusu>
    Reviewed-on: http://review.gluster.org/8966
    Reviewed-by: soumya k <skoduri>
    Reviewed-by: Raghavendra Talur <rtalur>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 1 Anand Avati 2014-10-27 07:19:12 UTC

REVIEW: http://review.gluster.org/8974 (Hooks : Infinite while loop introduced by another change.) posted (#1) for review on release-3.6 by Meghana M (mmadhusu)

Comment 2 Anand Avati 2014-10-28 10:21:38 UTC

COMMIT: http://review.gluster.org/8974 committed in release-3.6 by Vijay Bellur (vbellur) 
------
commit bf6196b876e487c8a37e148b92721f0d85bcfd43
Author: Meghana Madhusudhan <mmadhusu>
Date:   Tue Oct 21 19:50:29 2014 +0530

    Hooks : Infinite while loop introduced by another change.
    
    A change made to all the hook scripts introduced an
    infinite while loop in the script S31ganesha-reset.sh.
    It resulted in 100% CPU usage by this script.
    
    Change-Id: I8133c92d46616b6534fc88158d6dbfca49875f4a
    BUG: 1157374
    Reviewed-on: http://review.gluster.org/8974
    Reviewed-by: Raghavendra Talur <rtalur>
    Reviewed-by: soumya k <skoduri>
    Reviewed-by: Vijay Bellur <vbellur>
    Tested-by: Vijay Bellur <vbellur>

Comment 3 Niels de Vos 2014-11-10 15:14:27 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users