Bug 1157700
| Summary: | Review Request: php-ocramius-code-generator-utils - A set of code generator utilities built on top of PHP-Parsers | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shawn Iwinski <shawn> | ||||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | fedora, package-review | ||||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | php-ocramius-code-generator-utils-0.3.0-2.el7 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2014-11-16 14:47:23 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1157708 | ||||||||
| Attachments: |
|
||||||||
|
Description
Shawn Iwinski
2014-10-27 14:16:28 UTC
Created attachment 953491 [details]
phpci.log
phpCompatInfo version 3.5.0 static analyze run in src directory
Created attachment 953492 [details]
review.txt
Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Minor cleanup (no blocker) - ensure you use the correct spec (see review.txt) without the debug "find" - consider to silent the include (in test autoloader) to avoid some warning at build time Everything seems OK. === APPROVED === (In reply to Remi Collet from comment #3) > Minor cleanup (no blocker) > > - ensure you use the correct spec (see review.txt) without the debug "find" Oooops, my bad. That was a debug b/c of an issue w/ the previous PHPParser release. > - consider to silent the include (in test autoloader) to avoid some warning > at build time I'm not sure how that un-silenced. Perhaps during my debug. > Everything seems OK. > > === APPROVED === I'll make sure everything is cleaned up after initial import. THANKS for the review! New Package SCM Request ======================= Package Name: php-ocramius-code-generator-utils Short Description: A set of code generator utilities built on top of PHP-Parsers Upstream URL: https://github.com/Ocramius/CodeGenerationUtils Owners: siwinski Branches: f21 epel7 InitialCC: Git done (by process-git-requests). php-ocramius-code-generator-utils-0.3.0-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/php-ocramius-code-generator-utils-0.3.0-2.fc21 php-ocramius-code-generator-utils-0.3.0-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/php-ocramius-code-generator-utils-0.3.0-2.el7 php-ocramius-code-generator-utils-0.3.0-2.fc21 has been pushed to the Fedora 21 testing repository. php-ocramius-code-generator-utils-0.3.0-2.fc21 has been pushed to the Fedora 21 stable repository. php-ocramius-code-generator-utils-0.3.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository. |