Spec URL: https://raw.githubusercontent.com/siwinski/rpms/375ca5028ea7c8c7df11df954265a85a417ffee3/php-ocramius-code-generator-utils.spec SRPM URL: https://siwinski.fedorapeople.org/copr/php-experimental/php-ocramius-code-generator-utils-0.3.0-1.fc20.src.rpm Description: A set of code generator utilities built on top of PHP-Parsers that ease its use when combined with Reflection. Fedora Account System Username: siwinski COPR build: http://copr.fedoraproject.org/coprs/siwinski/php-experimental/build/55152/
Created attachment 953491 [details] phpci.log phpCompatInfo version 3.5.0 static analyze run in src directory
Created attachment 953492 [details] review.txt Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Minor cleanup (no blocker) - ensure you use the correct spec (see review.txt) without the debug "find" - consider to silent the include (in test autoloader) to avoid some warning at build time Everything seems OK. === APPROVED ===
(In reply to Remi Collet from comment #3) > Minor cleanup (no blocker) > > - ensure you use the correct spec (see review.txt) without the debug "find" Oooops, my bad. That was a debug b/c of an issue w/ the previous PHPParser release. > - consider to silent the include (in test autoloader) to avoid some warning > at build time I'm not sure how that un-silenced. Perhaps during my debug. > Everything seems OK. > > === APPROVED === I'll make sure everything is cleaned up after initial import.
THANKS for the review! New Package SCM Request ======================= Package Name: php-ocramius-code-generator-utils Short Description: A set of code generator utilities built on top of PHP-Parsers Upstream URL: https://github.com/Ocramius/CodeGenerationUtils Owners: siwinski Branches: f21 epel7 InitialCC:
Git done (by process-git-requests).
php-ocramius-code-generator-utils-0.3.0-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/php-ocramius-code-generator-utils-0.3.0-2.fc21
php-ocramius-code-generator-utils-0.3.0-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/php-ocramius-code-generator-utils-0.3.0-2.el7
php-ocramius-code-generator-utils-0.3.0-2.fc21 has been pushed to the Fedora 21 testing repository.
php-ocramius-code-generator-utils-0.3.0-2.fc21 has been pushed to the Fedora 21 stable repository.
php-ocramius-code-generator-utils-0.3.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository.