Bug 1157760

Summary: [RFE] Fedpkg should optionally honor existing source files to be kept
Product: [Fedora] Fedora Reporter: Raphael Groner <projects.rg>
Component: fedpkgAssignee: Dennis Gilmore <dennis>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: dennis, pbabinca, s
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-11-05 05:01:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Test file none

Description Raphael Groner 2014-10-27 15:59:48 UTC
Created attachment 951048 [details]
Test file

Description of problem:
Fedpkg should optionally honor compressed files as local source.

Version-Release number of selected component (if applicable):
fedpkg-1.19-1.fc20.noarch

How reproducible:
yes, always with gnurobbo SCM

Steps to Reproduce:
1. fedpkg new-sources *.png.bz2
2. 
3.

Actual results:
Nothing added to git but files appeaar in .gitignore, as well sources file gets corrupt.

Expected results:
fedpkg should implement a complex logic to differ between real binaries and/or additional source files, maybe compressed.

Additional info:
Do this with a force option? 
Alternatively, fedpkg could try to uncompress small file pieces and look inside the extract if it's textual.

Comment 1 Raphael Groner 2014-11-03 21:52:16 UTC
Maybe it's not quite clear how to use fedpkg new-sources. This RFE is more about having an option add-sources or the like. As it turns out, I've to give -all- available source files to new-sources, even if I want to add some only to the existing ones, otherwise the existed ones will be removed again from sources file.

Comment 2 Dennis Gilmore 2014-11-05 05:01:15 UTC
"fedpkg upload" is what you want to add a new tarball to existing ones.