Bug 1158126

Summary: md-cache checks for modification using whole seconds only
Product: [Community] GlusterFS Reporter: Philip Spencer <pspencer>
Component: coreAssignee: bugs <bugs>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 3.6.0CC: bugs, lmohanty, ndevos
Target Milestone: ---Keywords: EasyFix, Patch, Triaged
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1164506 (view as bug list) Environment:
Last Closed: 2016-08-30 12:42:14 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1164506    
Bug Blocks:    
Attachments:
Description Flags
Patch to make md-cache check subsecond timing values none

Description Philip Spencer 2014-10-28 16:05:18 UTC 
Created attachment 951443 [details]
Patch to make md-cache check subsecond timing values

This is one of the "other bugs" mentioned in bug #1158120.

When md-cache checks for an updated mtime/ctime in order to see if it should request a cache invalidation, it only looks at the whole-second "mtime" and "ctime" fields. If a file was modified a fraction of a second after the time of the cached data, md-cache won't notice the change.

The attached patch makes md-cache look at the mtime_nsec and ctime_nsec fields too.
Comment 1 Lalatendu Mohanty 2014-11-04 12:47:51 UTC 
Philip,

Thanks for the bug and patch. GlusterFS community uses Gerrit to review patches. Please refer below link to know developer work flow in GlusterFS community. If you are  interested to post the patch yourself , you are welcome to do so. If you want us to post the patch on your behalf let us know.

[1] http://www.gluster.org/community/documentation/index.php/Development_Work_Flow
Comment 2 Niels de Vos 2014-11-20 09:04:23 UTC 
http://review.gluster.org/9131 has been merged in master, and can get backported to 3.6:
- http://www.gluster.org/community/documentation/index.php/Backport_Guidelines
Comment 3 Niels de Vos 2016-08-30 12:42:14 UTC 
This bug is being closed as GlusterFS-3.6 is nearing its End-Of-Life and only important security bugs will be fixed. This bug has been fixed in more recent GlusterFS releases. If you still face this bug with the newer GlusterFS versions, please open a new bug.