Bug 1158126 - md-cache checks for modification using whole seconds only
Summary: md-cache checks for modification using whole seconds only
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: core
Version: 3.6.0
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: bugs@gluster.org
QA Contact:
URL:
Whiteboard:
Depends On: 1164506
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-10-28 16:05 UTC by Philip Spencer
Modified: 2016-08-30 12:42 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1164506 (view as bug list)
Environment:
Last Closed: 2016-08-30 12:42:14 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)
Patch to make md-cache check subsecond timing values (999 bytes, patch)
2014-10-28 16:05 UTC, Philip Spencer
no flags Details | Diff

Description Philip Spencer 2014-10-28 16:05:18 UTC
Created attachment 951443 [details]
Patch to make md-cache check subsecond timing values

This is one of the "other bugs" mentioned in bug #1158120.

When md-cache checks for an updated mtime/ctime in order to see if it should request a cache invalidation, it only looks at the whole-second "mtime" and "ctime" fields. If a file was modified a fraction of a second after the time of the cached data, md-cache won't notice the change.

The attached patch makes md-cache look at the mtime_nsec and ctime_nsec fields too.

Comment 1 Lalatendu Mohanty 2014-11-04 12:47:51 UTC
Philip,

Thanks for the bug and patch. GlusterFS community uses Gerrit to review patches. Please refer below link to know developer work flow in GlusterFS community. If you are  interested to post the patch yourself , you are welcome to do so. If you want us to post the patch on your behalf let us know.

[1] http://www.gluster.org/community/documentation/index.php/Development_Work_Flow

Comment 2 Niels de Vos 2014-11-20 09:04:23 UTC
http://review.gluster.org/9131 has been merged in master, and can get backported to 3.6:
- http://www.gluster.org/community/documentation/index.php/Backport_Guidelines

Comment 3 Niels de Vos 2016-08-30 12:42:14 UTC
This bug is being closed as GlusterFS-3.6 is nearing its End-Of-Life and only important security bugs will be fixed. This bug has been fixed in more recent GlusterFS releases. If you still face this bug with the newer GlusterFS versions, please open a new bug.


Note You need to log in before you can comment on or make changes to this bug.