Bug 115813

Summary: .spec file omissions
Product: [Fedora] Fedora Reporter: Ivan <david>
Component: opensshAssignee: Nalin Dahyabhai <nalin>
Status: CLOSED RAWHIDE QA Contact: Brian Brock <bbrock>
Severity: low Docs Contact:
Priority: medium    
Version: rawhideKeywords: EasyFix, Patch
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2004-09-15 12:43:41 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 114963, 123268    

Description Ivan 2004-02-16 12:12:56 UTC
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6)
Gecko/20040206 Firefox/0.8

Description of problem:
Bug 1
Remove (rpm -e) libselinux-devel and build (rpmbuild -bb) openssh.
You'll find rpmbuild will start and later bombs out bec libselinux is
not found. Should add "BuildPreReq: libselinux-devel" in .spec file.

Bug 2
Disable gnome_askpass by "%define no_gnome_askpass 0" and build
(rpmbuild -bb) openssh. It'll stop near the end, complaining abt
missing  gnome-ssh-askpass.*. Should add "%if ! %{no_gnome_askpass}"
conditional around said files.

Version-Release number of selected component (if applicable):
openssh-3.6.1p2-27

How reproducible:
Always

Steps to Reproduce:
1. rpm -e libselinux-devel
2. rpmbuild -bb openssh.spec


Additional info:

# diff -Naur openssh-3.6.1p2-27.spec.orig openssh-3.6.1p2-27.spec
--- openssh-3.6.1p2-27.spec.orig        2004-02-16 20:05:31.000000000
+0800
+++ openssh-3.6.1p2-27.spec     2004-02-16 20:08:37.000000000 +0800
@@ -121,6 +121,7 @@
 BuildPreReq: gtk2-devel
 %endif
 BuildPreReq: openssl-devel, perl, sharutils, tcp_wrappers, zlib-devel
+BuildPreReq: libselinux-devel
 BuildPreReq: /bin/login
 
 %if %{build6x}
@@ -356,8 +357,10 @@
 %endif
 
 install -m 755 -d $RPM_BUILD_ROOT%{_sysconfdir}/profile.d/
+%if ! %{no_gnome_askpass}
 install -m 755 contrib/redhat/gnome-ssh-askpass.csh
$RPM_BUILD_ROOT%{_sysconfdir}/profile.d/
 install -m 755 contrib/redhat/gnome-ssh-askpass.sh
$RPM_BUILD_ROOT%{_sysconfdir}/profile.d/
+%endif
 
 perl -pi -e "s|$RPM_BUILD_ROOT||g" $RPM_BUILD_ROOT%{_mandir}/man*/*

Comment 1 Karsten Hopp 2004-09-15 12:43:41 UTC
fixed in the current version