Bug 1159024
| Summary: | [PATCH] add rhel-5.9..11 and rhel-6.6 info to libosinfo | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Satoru SATOH <ssato> |
| Component: | libosinfo | Assignee: | Daniel Berrangé <berrange> |
| Status: | CLOSED UPSTREAM | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 20 | CC: | berrange, cfergeau, crobinso, virt-maint, zeenix |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-04-14 22:50:14 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Attachments: | |||
|
Description
Satoru SATOH
2014-10-30 17:37:35 UTC
Created attachment 952377 [details]
Revised patch to add RHEL 5.9..11 and RHEL 6.6
Sorry, I wrongly made a patch for rhel.xml instead of rhel.xml.in.
I made another patch to correct this.
Created attachment 952378 [details]
One more patch to fix upgrades and derives-from of RHEL {5.9,6.6}
Excuse me, one more fix to correct //upgrades and //derives-from of RHEL {5.9, 6.6}.
Thanks for the patches! The upgrade info for 5.10/5.11 needs fixing too. If you have the isos for these versions of RHEL, it would be great if you could add the output of "isoinfo -d -i xxx.iso" to the testsuite too. A patch generated with git format-patch would be ideal for easier application. Created attachment 953100 [details]
A patch to add rhel-5.{9,10,11} and rhel-6.6 info data
Created attachment 953101 [details]
Patch to add test/isodata of RHEL 5.{9..11} and RHEL 6.6
I've not tested these yet but post here just in case.
You can test these by running 'make check', and this actually uncovers an issue with your patch, the volume id for rhel 6.6 is different than previous versions: - <volume-id>.*RHEL_6.6 x86_64.*</volume-id> + <volume-id>.*RHEL-6.6 .*.x86_64.*</volume-id> Created attachment 954502 [details]
Updated patch
Let me know if this patch looks good to you (including the commit log and your name/email).
Thank you for the clean up of the patches. LGTM! This is upstream now, so closing |