Bug 1159024 - [PATCH] add rhel-5.9..11 and rhel-6.6 info to libosinfo
Summary: [PATCH] add rhel-5.9..11 and rhel-6.6 info to libosinfo
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: libosinfo
Version: 20
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Daniel Berrangé
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-10-30 17:37 UTC by Satoru SATOH
Modified: 2015-04-14 22:50 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-04-14 22:50:14 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
patch to add rhel-5.9..11 and rhel-6.6 info to libosinfo (5.17 KB, patch)
2014-10-30 17:37 UTC, Satoru SATOH
no flags Details | Diff
Revised patch to add RHEL 5.9..11 and RHEL 6.6 (4.18 KB, patch)
2014-10-31 02:02 UTC, Satoru SATOH
no flags Details | Diff
One more patch to fix upgrades and derives-from of RHEL {5.9,6.6} (1.04 KB, patch)
2014-10-31 02:08 UTC, Satoru SATOH
no flags Details | Diff
A patch to add rhel-5.{9,10,11} and rhel-6.6 info data (4.48 KB, patch)
2014-11-03 13:36 UTC, Satoru SATOH
no flags Details | Diff
Patch to add test/isodata of RHEL 5.{9..11} and RHEL 6.6 (7.48 KB, patch)
2014-11-03 13:39 UTC, Satoru SATOH
no flags Details | Diff
Updated patch (11.49 KB, patch)
2014-11-06 15:34 UTC, Christophe Fergeau
no flags Details | Diff

Description Satoru SATOH 2014-10-30 17:37:35 UTC
Created attachment 952291 [details]
patch to add rhel-5.9..11 and rhel-6.6 info to libosinfo

Description of problem:
Some recent RHEL releases are missing in the database in libosinfo
and I made an experimental patch to fix this.

The data (release-date, etc.) are taken from:
https://access.redhat.com/articles/3078


Version-Release number of selected component (if applicable):
As far as I checked, it master HEAD, latest version in F20, F21
look having this issue.

Comment 1 Satoru SATOH 2014-10-31 02:02:59 UTC
Created attachment 952377 [details]
Revised patch to add RHEL 5.9..11 and RHEL 6.6

Sorry, I wrongly made a patch for rhel.xml instead of rhel.xml.in.
I made another patch to correct this.

Comment 2 Satoru SATOH 2014-10-31 02:08:27 UTC
Created attachment 952378 [details]
One more patch to fix upgrades and derives-from of RHEL {5.9,6.6}

Excuse me, one more fix to correct //upgrades and //derives-from of RHEL {5.9, 6.6}.

Comment 3 Christophe Fergeau 2014-10-31 13:04:48 UTC
Thanks for the patches!
The upgrade info for 5.10/5.11 needs fixing too. If you have the isos for these versions of RHEL, it would be great if you could add the output of "isoinfo -d -i xxx.iso" to the testsuite too.
A patch generated with git format-patch would be ideal for easier application.

Comment 4 Satoru SATOH 2014-11-03 13:36:57 UTC
Created attachment 953100 [details]
A patch to add rhel-5.{9,10,11} and rhel-6.6 info data

Comment 5 Satoru SATOH 2014-11-03 13:39:03 UTC
Created attachment 953101 [details]
Patch to add test/isodata of RHEL 5.{9..11} and RHEL 6.6

I've not tested these yet but post here just in case.

Comment 6 Christophe Fergeau 2014-11-06 15:32:46 UTC
You can test these by running 'make check', and this actually uncovers an issue with your patch, the volume id for rhel 6.6 is different than previous versions:
-        <volume-id>.*RHEL_6.6 x86_64.*</volume-id>
+        <volume-id>.*RHEL-6.6 .*.x86_64.*</volume-id>

Comment 7 Christophe Fergeau 2014-11-06 15:34:17 UTC
Created attachment 954502 [details]
Updated patch

Let me know if this patch looks good to you (including the commit log and your name/email).

Comment 8 Satoru SATOH 2014-11-09 12:39:27 UTC
Thank you for the clean up of the patches. LGTM!

Comment 9 Cole Robinson 2015-04-14 22:50:14 UTC
This is upstream now, so closing


Note You need to log in before you can comment on or make changes to this bug.