Bug 1159829 (lxqt-openssh-askpass)
| Summary: | Review Request: lxqt-openssh-askpass - Askpass openssh transition dialog for LXQt desktop suite | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Helio Chissini de Castro <hcastro> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | helio, jmunilla, jonathan.underwood, mtasaka, package-review, projects.rg, rdieter, ti.eugene |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-01-26 12:38:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1157402 | ||
| Bug Blocks: | |||
|
Description
Helio Chissini de Castro
2014-11-03 13:04:30 UTC
naming: ok license: ok, could be ammended to License: LGPLv2+ sources: ok 74e0fd9f684b4e855ea1c5accbd64d10 lxqt-openssh-askpass-0.8.0.tar.xz macros: ok scriptlets: ok (n/a) thanks for moving to libexecdir, not sure if it's worth worrying about what happens when > 1 openssh-askpass provider is installed, and they stomp on each others' SSH_ASKPASS= env assignments, but I suppose that's outside the purview of this review APPROVED Oops... not this review, sorry. * Does not build http://koji.fedoraproject.org/koji/taskinfo?taskID=8068602 The build failure was due to a naive attempt of ours to change the liblxqt cmake files, it does not reflect upon this review. Updated with: https://heliocastro.fedorapeople.org/lxqt/lxqt-openssh-askpass-0.8.0-3.fc21.src.rpm https://heliocastro.fedorapeople.org/lxqt/lxqt-openssh-askpass.spec New Package SCM Request ======================= Package Name: lxqt-openssh-askpass Short Description: Askpass openssh transition dialog for LXQt Upstream URL: http://lxqt.org Owners: heliocastro rdieter tieugene Branches: f20 f21 el6 epel7 InitialCC: heliocastro New Package SCM Request ======================= Package Name: lxqt-openssh-askpass Short Description: Askpass openssh transition dialog for LXQt Upstream URL: http://lxqt.org/ Owners: heliocastro rdieter tieugene Branches: f20 f21 el6 epel7 InitialCC: Git done (by process-git-requests). Shouldn't this be closed? |