Spec URL: https://heliocastro.fedorapeople.org/lxqt/lxqt-notificationd.spec SRPM URL: https://heliocastro.fedorapeople.org/lxqt/lxqt-openssh-askpass-0.8.0-2.fc21.src.rpm Description: Askpass openssh transition dialog for LXQt desktop suite Fedora Account System Username: heliocastro
naming: ok license: ok, could be ammended to License: LGPLv2+ sources: ok 74e0fd9f684b4e855ea1c5accbd64d10 lxqt-openssh-askpass-0.8.0.tar.xz macros: ok scriptlets: ok (n/a) thanks for moving to libexecdir, not sure if it's worth worrying about what happens when > 1 openssh-askpass provider is installed, and they stomp on each others' SSH_ASKPASS= env assignments, but I suppose that's outside the purview of this review APPROVED
* https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#desktop-file-install_usage
Oops... not this review, sorry.
* Does not build http://koji.fedoraproject.org/koji/taskinfo?taskID=8068602
The build failure was due to a naive attempt of ours to change the liblxqt cmake files, it does not reflect upon this review.
Updated with: https://heliocastro.fedorapeople.org/lxqt/lxqt-openssh-askpass-0.8.0-3.fc21.src.rpm https://heliocastro.fedorapeople.org/lxqt/lxqt-openssh-askpass.spec
New Package SCM Request ======================= Package Name: lxqt-openssh-askpass Short Description: Askpass openssh transition dialog for LXQt Upstream URL: http://lxqt.org Owners: heliocastro rdieter tieugene Branches: f20 f21 el6 epel7 InitialCC: heliocastro
New Package SCM Request ======================= Package Name: lxqt-openssh-askpass Short Description: Askpass openssh transition dialog for LXQt Upstream URL: http://lxqt.org/ Owners: heliocastro rdieter tieugene Branches: f20 f21 el6 epel7 InitialCC:
Git done (by process-git-requests).
Shouldn't this be closed?