Bug 1161126
| Summary: | Review Request: perl-Config-AutoConf - A module to implement some of AutoConf macros in pure perl | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Šabata <psabata> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | cbm, package-review, ppisar |
| Target Milestone: | --- | Flags: | ppisar:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Config-AutoConf-0.305-1.fc22 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-11-06 16:39:54 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 839612, 1165620 | ||
|
Description
Petr Šabata
2014-11-06 12:56:34 UTC
URL and Source0 are usable. Ok.
Source archive is original (SHA-256: 7905d7752f0afedca0d6a0f008b8b489519c0b01dedc50de1fcce74520253cc0). Ok.
License verified from README and lib/Config/AutoConf.pm. Ok.
Summary verified from lib/Config/AutoConf.pm. Ok.
TODO: Spell `perl' with uppercase initial letter in the summary.
Description verified from lib/Config/AutoConf.pm. Ok.
File::Slurp::Tiny is optional. Ok.
Scalar::Util is optional. Ok.
IO::String needed only for old perls. Ok.
TODO: Build-require and run-require `glibc-headers' because the code tries to compile a code with `#include <stdio.h>' text etc. (lib/Config/AutoConf.pm:2375)
All tests pass. Ok.
$ rpmlint perl-Config-AutoConf.spec ../SRPMS/perl-Config-AutoConf-0.305-1.fc22.src.rpm ../RPMS/noarch/perl-Config-AutoConf-0.305-1.fc22.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-Config-AutoConf-0.305-1.fc22.noarch.rpm
drwxr-xr-x 2 root root 0 Nov 6 16:58 /usr/share/doc/perl-Config-AutoConf
-rw-r--r-- 1 root root 6346 Jun 12 20:18 /usr/share/doc/perl-Config-AutoConf/Changes
-rw-r--r-- 1 root root 560 Apr 7 2014 /usr/share/doc/perl-Config-AutoConf/README
-rw-r--r-- 1 root root 9834 Nov 6 16:57 /usr/share/man/man3/Config::AutoConf.3pm.gz
drwxr-xr-x 2 root root 0 Nov 6 16:57 /usr/share/perl5/vendor_perl/Config
-rw-r--r-- 1 root root 71147 Jun 12 20:18 /usr/share/perl5/vendor_perl/Config/AutoConf.pm
File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Config-AutoConf-0.305-1.fc22.noarch.rpm | sort -f | uniq -c
1 perl(:MODULE_COMPAT_5.20.1)
1 perl(base)
1 perl(Capture::Tiny)
1 perl(Carp)
1 perl(Config)
1 perl(constant)
1 perl(Exporter)
1 perl(ExtUtils::CBuilder)
1 perl(File::Basename)
1 perl(File::Spec)
1 perl(File::Temp)
1 perl(strict)
1 perl(Text::ParseWords)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
$ rpm -q --provides -p ../RPMS/noarch/perl-Config-AutoConf-0.305-1.fc22.noarch.rpm | sort -f | uniq -c
1 perl(Config::AutoConf) = 0.305
1 perl-Config-AutoConf = 0.305-1.fc22
Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-Config-AutoConf-0.305-1.fc22.noarch.rpm
Binary dependencies resolvable. Ok.
Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=8055853). Ok.
Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please consider fixing `TODO' items before building this package.
Resolution: Package APPROVED.
New Package SCM Request ======================= Package Name: perl-Config-AutoConf Short Description: A module to implement some of AutoConf macros in pure Perl Upstream URL: http://search.cpan.org/dist/Config-AutoConf/ Owners: psabata jplesnik ppisar Branches: InitialCC: perl-sig Git done (by process-git-requests). Thank you. Both suggestions included. *** Bug 1165634 has been marked as a duplicate of this bug. *** Colin, if you need this package for different Fedora release than Fedora 22, just ask, and I will arrange it. Yes F21 would be great, thanks! I wasn't going to bother with F19/F20 (they can keep using my biber-1.8 copr. Package Change Request ====================== Package Name: perl-Config-AutoConf New Branches: f21 Owners: psabata jplesnik ppisar InitialCC: perl-sig Git done (by process-git-requests). perl-Config-AutoConf-0.305-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/perl-Config-AutoConf-0.305-1.fc21 Okay, update submitted. Beware you won't be able to build biber for F21 until perl-Config-AutoConf-0.305-1.fc21 lands in stable (which will, given F21's currently frozen, take a while) or you create a buildroot override with it. perl-Config-AutoConf-0.305-1.fc21 has been pushed to the Fedora 21 stable repository. |