Bug 1161126 - Review Request: perl-Config-AutoConf - A module to implement some of AutoConf macros in pure perl
Summary: Review Request: perl-Config-AutoConf - A module to implement some of AutoConf...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1165634 (view as bug list)
Depends On:
Blocks: 839612 1165620
TreeView+ depends on / blocked
 
Reported: 2014-11-06 12:56 UTC by Petr Šabata
Modified: 2014-12-06 10:24 UTC (History)
3 users (show)

Fixed In Version: perl-Config-AutoConf-0.305-1.fc22
Clone Of:
Environment:
Last Closed: 2014-11-06 16:39:54 UTC
Type: ---
Embargoed:
ppisar: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Šabata 2014-11-06 12:56:34 UTC
Spec URL: https://psabata.fedorapeople.org/pkgs/perl-Config-AutoConf/perl-Config-AutoConf.spec
SRPM URL: https://psabata.fedorapeople.org/pkgs/perl-Config-AutoConf/perl-Config-AutoConf-0.305-1.fc20.src.rpm
Description:
This module simulates some of the tasks autoconf macros do.  To detect
a command, a library and similar.
Fedora Account System Username: psabata

Comment 1 Petr Pisar 2014-11-06 16:10:29 UTC
URL and Source0 are usable. Ok.
Source archive is original (SHA-256: 7905d7752f0afedca0d6a0f008b8b489519c0b01dedc50de1fcce74520253cc0). Ok.
License verified from README and lib/Config/AutoConf.pm. Ok.
Summary verified from lib/Config/AutoConf.pm. Ok.

TODO: Spell `perl' with uppercase initial letter in the summary.

Description verified from lib/Config/AutoConf.pm. Ok.
File::Slurp::Tiny is optional. Ok.
Scalar::Util is optional. Ok.
IO::String needed only for old perls. Ok.

TODO: Build-require and run-require `glibc-headers' because the code tries to compile a code with `#include <stdio.h>' text etc. (lib/Config/AutoConf.pm:2375)

All tests pass. Ok.

$ rpmlint perl-Config-AutoConf.spec ../SRPMS/perl-Config-AutoConf-0.305-1.fc22.src.rpm ../RPMS/noarch/perl-Config-AutoConf-0.305-1.fc22.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Config-AutoConf-0.305-1.fc22.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Nov  6 16:58 /usr/share/doc/perl-Config-AutoConf
-rw-r--r--    1 root    root                     6346 Jun 12 20:18 /usr/share/doc/perl-Config-AutoConf/Changes
-rw-r--r--    1 root    root                      560 Apr  7  2014 /usr/share/doc/perl-Config-AutoConf/README
-rw-r--r--    1 root    root                     9834 Nov  6 16:57 /usr/share/man/man3/Config::AutoConf.3pm.gz
drwxr-xr-x    2 root    root                        0 Nov  6 16:57 /usr/share/perl5/vendor_perl/Config
-rw-r--r--    1 root    root                    71147 Jun 12 20:18 /usr/share/perl5/vendor_perl/Config/AutoConf.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Config-AutoConf-0.305-1.fc22.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.20.1)
      1 perl(base)
      1 perl(Capture::Tiny)
      1 perl(Carp)
      1 perl(Config)
      1 perl(constant)
      1 perl(Exporter)
      1 perl(ExtUtils::CBuilder)
      1 perl(File::Basename)
      1 perl(File::Spec)
      1 perl(File::Temp)
      1 perl(strict)
      1 perl(Text::ParseWords)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Config-AutoConf-0.305-1.fc22.noarch.rpm | sort -f | uniq -c
      1 perl(Config::AutoConf) = 0.305
      1 perl-Config-AutoConf = 0.305-1.fc22
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Config-AutoConf-0.305-1.fc22.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=8055853). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.

Please consider fixing `TODO' items before building this package.
Resolution: Package APPROVED.

Comment 2 Petr Šabata 2014-11-06 16:17:53 UTC
New Package SCM Request
=======================
Package Name: perl-Config-AutoConf
Short Description: A module to implement some of AutoConf macros in pure Perl
Upstream URL: http://search.cpan.org/dist/Config-AutoConf/
Owners: psabata jplesnik ppisar
Branches: 
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2014-11-06 16:22:14 UTC
Git done (by process-git-requests).

Comment 4 Petr Šabata 2014-11-06 16:39:54 UTC
Thank you.

Both suggestions included.

Comment 5 Petr Šabata 2014-11-19 12:13:06 UTC
*** Bug 1165634 has been marked as a duplicate of this bug. ***

Comment 6 Petr Pisar 2014-11-19 12:26:51 UTC
Colin, if you need this package for different Fedora release than Fedora 22, just ask, and I will arrange it.

Comment 7 Colin Macdonald 2014-11-19 12:37:09 UTC
Yes F21 would be great, thanks!

I wasn't going to bother with F19/F20 (they can keep using my biber-1.8 copr.

Comment 8 Petr Pisar 2014-11-19 13:24:10 UTC
Package Change Request
======================
Package Name: perl-Config-AutoConf
New Branches: f21
Owners: psabata jplesnik ppisar
InitialCC: perl-sig

Comment 9 Gwyn Ciesla 2014-11-19 13:30:31 UTC
Git done (by process-git-requests).

Comment 10 Fedora Update System 2014-11-19 14:29:03 UTC
perl-Config-AutoConf-0.305-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/perl-Config-AutoConf-0.305-1.fc21

Comment 11 Petr Šabata 2014-11-19 14:33:34 UTC
Okay, update submitted.

Beware you won't be able to build biber for F21 until perl-Config-AutoConf-0.305-1.fc21 lands in stable (which will, given F21's currently frozen, take a while) or you create a buildroot override with it.

Comment 12 Fedora Update System 2014-12-06 10:24:59 UTC
perl-Config-AutoConf-0.305-1.fc21 has been pushed to the Fedora 21 stable repository.


Note You need to log in before you can comment on or make changes to this bug.