Bug 1161135

Summary:	openshift-sni-proxy restart command needs call 'oo-rebuild-haproxy-sni-proxy' function
Product:	OpenShift Online	Reporter:	Luke Meyer <lmeyer>
Component:	Containers	Assignee:	Luke Meyer <lmeyer>
Status:	CLOSED CURRENTRELEASE	QA Contact:	libra bugs <libra-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	2.x	CC:	bleanhar, bmeng, bperkins, jokerman, libra-bugs, libra-onpremise-devel, lmeyer, mmccomas, xjia
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1160562	Environment:
Last Closed:	2015-02-18 16:52:47 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1160562, 1161136

Description Luke Meyer 2014-11-06 13:25:26 UTC

+++ This bug was initially created as a clone of Bug #1160562 +++

Description of problem:
If changing something in /etc/openshift/node-plugins.d/openshift-origin-frontend-haproxy-sni-proxy.conf. Need to restart openshift-sni-proxy.  But it doesn't call 'oo-rebuild-haproxy-sni-proxy' function. 

/etc/init.d/openshift-sni-proxy: 

restart() {
    $exec -c -q -f $cfgfile
    if [ $? -ne 0 ]; then
        echo "Errors in configuration file, check with $prog check."
        return 1
    fi
    stop
    start
}

case "$1" in
    start)
        # Fix the IP address and config params if they changed.
        oo-rebuild-haproxy-sni-proxy || :
        start
        ;;
    stop|restart|reload)
        $1
        ;;
    force-reload)
        restart
        ;;

Version-Release number of selected component (if applicable):
OSE-2.2 2014-10-29.1

How reproducible:
always

Steps to Reproduce:
1.
2.
3.

Actual results:
oo-rebuild-haproxy-sni-proxy is not called

Expected results:
oo-rebuild-haproxy-sni-proxy should be run when restarting openshift-sni-proxy service

Additional info:

Comment 2 openshift-github-bot 2014-11-06 22:06:03 UTC

Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/7599f7cda80e9090a3ccaed560865e211cdea787
sni-proxy: have restart re-create conf

"service openshift-sni-proxy start" caused haproxy conf to be re-created
according to the plugin conf file, but not a restart. This change causes
oo-rebuild-haproxy-sni-proxy to be run either way.

Bug 1161135 - openshift-sni-proxy restart command needs call
'oo-rebuild-haproxy-sni-proxy' function
https://bugzilla.redhat.com/show_bug.cgi?id=1161135

Comment 3 Meng Bo 2014-11-07 10:19:57 UTC

Checked on devenv_5286, the oo-rebuild-haproxy-sni-proxy will be called in both start and restart actions.

Comment 4 JBoss JIRA Server 2014-11-10 03:25:02 UTC

Xuan Jia <xjia> updated the status of jira ENTESB-2162 to Closed