Restarting the openshift-sni-proxy service did not call the oo-rebuild-haproxy-sni-proxy function, which is required to rebuild the HAProxy configuration. As a result, if SNI proxy plug-in configuration changes had been made, they were not reflected on a service restart. This bug fix updates the SNI proxy plug-in and now a rebuild of the configuration is initiated prior to startup when either starting or restarting the openshift-sni-proxy service.
Description of problem:
If changing something in /etc/openshift/node-plugins.d/openshift-origin-frontend-haproxy-sni-proxy.conf. Need to restart openshift-sni-proxy. But it doesn't call 'oo-rebuild-haproxy-sni-proxy' function.
/etc/init.d/openshift-sni-proxy:
restart() {
$exec -c -q -f $cfgfile
if [ $? -ne 0 ]; then
echo "Errors in configuration file, check with $prog check."
return 1
fi
stop
start
}
case "$1" in
start)
# Fix the IP address and config params if they changed.
oo-rebuild-haproxy-sni-proxy || :
start
;;
stop|restart|reload)
$1
;;
force-reload)
restart
;;
Version-Release number of selected component (if applicable):
OSE-2.2 2014-10-29.1
How reproducible:
always
Steps to Reproduce:
1.
2.
3.
Actual results:
oo-rebuild-haproxy-sni-proxy is not called
Expected results:
oo-rebuild-haproxy-sni-proxy should be run when restarting openshift-sni-proxy service
Additional info:
Checked in puddle-2-2-2014-11-24
oo-rebuild-haproxy-sni-proxy was moved to start.
/etc/init.d/openshift-sni-proxy {start|stop|status|restart|try-restart|reload|try-reload|force-reload} works
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.
https://rhn.redhat.com/errata/RHBA-2014-1979.html
Description of problem: If changing something in /etc/openshift/node-plugins.d/openshift-origin-frontend-haproxy-sni-proxy.conf. Need to restart openshift-sni-proxy. But it doesn't call 'oo-rebuild-haproxy-sni-proxy' function. /etc/init.d/openshift-sni-proxy: restart() { $exec -c -q -f $cfgfile if [ $? -ne 0 ]; then echo "Errors in configuration file, check with $prog check." return 1 fi stop start } case "$1" in start) # Fix the IP address and config params if they changed. oo-rebuild-haproxy-sni-proxy || : start ;; stop|restart|reload) $1 ;; force-reload) restart ;; Version-Release number of selected component (if applicable): OSE-2.2 2014-10-29.1 How reproducible: always Steps to Reproduce: 1. 2. 3. Actual results: oo-rebuild-haproxy-sni-proxy is not called Expected results: oo-rebuild-haproxy-sni-proxy should be run when restarting openshift-sni-proxy service Additional info: