Bug 1160562 - openshift-sni-proxy restart command needs call 'oo-rebuild-haproxy-sni-proxy' function
Summary: openshift-sni-proxy restart command needs call 'oo-rebuild-haproxy-sni-proxy'...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Containers
Version: 2.2.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: ---
Assignee: Brenton Leanhardt
QA Contact: libra bugs
URL:
Whiteboard:
Depends On: 1161135
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-11-05 07:36 UTC by xjia
Modified: 2015-07-20 00:52 UTC (History)
9 users (show)

Fixed In Version: rubygem-openshift-origin-frontend-haproxy-sni-proxy-0.4.2-1
Doc Type: Bug Fix
Doc Text:
Restarting the openshift-sni-proxy service did not call the oo-rebuild-haproxy-sni-proxy function, which is required to rebuild the HAProxy configuration. As a result, if SNI proxy plug-in configuration changes had been made, they were not reflected on a service restart. This bug fix updates the SNI proxy plug-in and now a rebuild of the configuration is initiated prior to startup when either starting or restarting the openshift-sni-proxy service.
Clone Of:
: 1161135 1161136 (view as bug list)
Environment:
Last Closed: 2014-12-10 13:25:00 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker ENTESB-2162 0 Major Closed OSE 2.2. command "oo-rebuild-haproxy-sni-proxy" needs to be documented 2014-11-10 03:25:01 UTC
Red Hat Product Errata RHBA-2014:1979 0 normal SHIPPED_LIVE Red Hat OpenShift Enterprise 2.2.2 bug fix and enhancement update 2014-12-10 18:23:46 UTC

Description xjia 2014-11-05 07:36:31 UTC
Description of problem:
If changing something in /etc/openshift/node-plugins.d/openshift-origin-frontend-haproxy-sni-proxy.conf. Need to restart openshift-sni-proxy.  But it doesn't call 'oo-rebuild-haproxy-sni-proxy' function. 

/etc/init.d/openshift-sni-proxy: 

restart() {
    $exec -c -q -f $cfgfile
    if [ $? -ne 0 ]; then
        echo "Errors in configuration file, check with $prog check."
        return 1
    fi
    stop
    start
}

case "$1" in
    start)
        # Fix the IP address and config params if they changed.
        oo-rebuild-haproxy-sni-proxy || :
        start
        ;;
    stop|restart|reload)
        $1
        ;;
    force-reload)
        restart
        ;;

Version-Release number of selected component (if applicable):
OSE-2.2 2014-10-29.1

How reproducible:
always

Steps to Reproduce:
1.
2.
3.

Actual results:
oo-rebuild-haproxy-sni-proxy is not called

Expected results:
oo-rebuild-haproxy-sni-proxy should be run when restarting openshift-sni-proxy service

Additional info:

Comment 2 xjia 2014-11-06 09:12:38 UTC
Can this bug be fixed in OSE-2.1.9? It's very easy to fix.

Comment 5 JBoss JIRA Server 2014-11-10 03:25:01 UTC
Xuan Jia <xjia> updated the status of jira ENTESB-2162 to Closed

Comment 8 Anping Li 2014-11-25 09:19:10 UTC
Checked in puddle-2-2-2014-11-24
oo-rebuild-haproxy-sni-proxy was moved to start.

/etc/init.d/openshift-sni-proxy {start|stop|status|restart|try-restart|reload|try-reload|force-reload} works

Comment 10 errata-xmlrpc 2014-12-10 13:25:00 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2014-1979.html


Note You need to log in before you can comment on or make changes to this bug.