Bug 1162230
| Summary: | quota xattrs are exposed in lookup and getxattr | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Pranith Kumar K <pkarampu> |
| Component: | quota | Assignee: | Pranith Kumar K <pkarampu> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 3.5.3 | CC: | bugs, gluster-bugs, lmohanty, ndevos |
| Target Milestone: | --- | Keywords: | Patch, Triaged |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.5.4 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1161106 | Environment: | |
| Last Closed: | 2015-06-03 21:08:29 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1161106, 1163569 | ||
| Bug Blocks: | 1141158 | ||
|
Description
Pranith Kumar K
2014-11-10 15:33:50 UTC
REVIEW: http://review.gluster.org/9090 (cluster/afr: Fix xattr heal comparison checks) posted (#1) for review on release-3.5 by Pranith Kumar Karampuri (pkarampu) REVIEW: http://review.gluster.org/9091 (features/marker: Filter internal xattrs in lookup) posted (#1) for review on release-3.5 by Pranith Kumar Karampuri (pkarampu) REVIEW: http://review.gluster.org/9091 (features/marker: Filter internal xattrs in lookup) posted (#2) for review on release-3.5 by Pranith Kumar Karampuri (pkarampu) REVIEW: http://review.gluster.org/9090 (cluster/afr: Fix xattr heal comparison checks) posted (#2) for review on release-3.5 by Pranith Kumar Karampuri (pkarampu) REVIEW: http://review.gluster.org/9090 (cluster/afr: Fix xattr heal comparison checks) posted (#3) for review on release-3.5 by Pranith Kumar Karampuri (pkarampu) COMMIT: http://review.gluster.org/9090 committed in release-3.5 by Niels de Vos (ndevos) ------ commit 909eb5671db37ff1388613929fe22883a4677da0 Author: Pranith Kumar K <pkarampu> Date: Fri Nov 7 09:21:10 2014 +0530 cluster/afr: Fix xattr heal comparison checks Backport of part of the fixes in http://review.gluster.org/8558 Problem: While implementing list-xattr based meta-data self-heal for afr-v2 we found 2 issues, with afr-v1's implementation. 1) change in QUOTA_SIZE_KEY xattr value can trigger spurious metadata self-heal. 2) xattr comparison function that is implemented for afr-v1 checks if the number of xattrs in both the xattrs is same and then checks that the xattrs present in brick-1's response are present and equal. But what we observed me was that count also contains the gluster internal/virtual xattrs where as the compare function should only compare on-disk external xattrs that can be healed. So the correct implementation should check that the external xattrs in first brick's response are present in second brick's response and vide versa. Fix: This patch is partly backported from afr-v2's implementation. Will be providing the links where necessary. 1) Added QUOTA_SIZE_KEY xattr to the list of xattrs that need to be ignored. (http://review.gluster.org/#/c/8558/10/xlators/cluster/afr/src/afr-common.c line: 1155) 2) For xattrs to be equal, check all keys in xattr-dict1 are in xattr-dict2 and equal and vice versa. (http://review.gluster.org/#/c/8558/10/xlators/cluster/afr/src/afr-common.c line: 1195) Change-Id: I63aa74858c6f608b98d1fe425b3fa56f925bb5b3 BUG: 1162230 Signed-off-by: Pranith Kumar K <pkarampu> Reviewed-on: http://review.gluster.org/9090 Reviewed-by: Niels de Vos <ndevos> Tested-by: Gluster Build System <jenkins.com> COMMIT: http://review.gluster.org/9091 committed in release-3.5 by Niels de Vos (ndevos) ------ commit 6e4e21c689c2e4b96a564afb2f0a3972e7829a53 Author: Pranith Kumar K <pkarampu> Date: Thu Nov 6 10:37:06 2014 +0530 features/marker: Filter internal xattrs in lookup Backport of http://review.gluster.com/9061 Afr should ignore quota-size-key as part of self-heal but should heal quota-limit key. BUG: 1162230 Change-Id: I639cfabbc44468da29914096afc7e2eca1ff1292 Signed-off-by: Pranith Kumar K <pkarampu> Reviewed-on: http://review.gluster.org/9091 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Ravishankar N <ravishankar> Reviewed-by: Raghavendra G <rgowdapp> Reviewed-by: Krutika Dhananjay <kdhananj> Reviewed-by: Niels de Vos <ndevos> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.4, please reopen this bug report. glusterfs-3.5.4 has been announced on the Gluster Packaging mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.packaging/2 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user *** Bug 1161502 has been marked as a duplicate of this bug. *** |