Bug 1162616

Summary:	Provide sensible default to config_opts['plugin_conf']['lvm_root_opts']['size']
Product:	[Fedora] Fedora	Reporter:	Vít Ondruch <vondruch>
Component:	mock	Assignee:	Michael Simacek <msimacek>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	20	CC:	jdisnard, mebrown, msimacek, msuchy, praiskup, williams
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-11-11 17:16:55 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Vít Ondruch 2014-11-11 11:32:53 UTC

Description of problem:
When the  config_opts['plugin_conf']['lvm_root_opts']['size'] is not specified, mock fails with "ERROR: 'size'". However, I believe there should be some sensible default.

Version-Release number of selected component (if applicable):
$ rpm -q mock
mock-1.2.0-1.fc20.noarch


How reproducible:
Always


Steps to Reproduce:
1. Set "config_opts['plugin_conf']['lvm_root_enable'] = True" in site-defaults.csf
2. But don't specify size.
3.

Actual results:
"ERROR: 'size'"

Expected results:
Sensible default size is used.

Additional info:

Comment 1 Michael Simacek 2014-11-11 17:16:55 UTC

There is no sensible default. There are people that use mock to rebuild just some small package and 1GB should be sufficient for them. On the other hand there are people who will share the pool across multiple configs and need to rebuild big packages such as libreoffice (it needs 5GB IIRC), so they will need more than 10GB. There used to be a default, but I removed it for this reason.

We agreed with Vit on IRC that it would instead be sensible to have a default for pool_name, which will result into sharing the pool across all configurations with lvm plugin enabled. Therefore the decision regarding the size will be made just once.