Bug 1162616 - Provide sensible default to config_opts['plugin_conf']['lvm_root_opts']['size']
Summary: Provide sensible default to config_opts['plugin_conf']['lvm_root_opts']['size']
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: mock
Version: 20
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michael Simacek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-11-11 11:32 UTC by Vít Ondruch
Modified: 2014-11-12 08:32 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-11-11 17:16:55 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1163008 0 unspecified CLOSED RFE: The pool should be shared between all build roots 2021-02-22 00:41:40 UTC

Internal Links: 1163008

Description Vít Ondruch 2014-11-11 11:32:53 UTC
Description of problem:
When the  config_opts['plugin_conf']['lvm_root_opts']['size'] is not specified, mock fails with "ERROR: 'size'". However, I believe there should be some sensible default.

Version-Release number of selected component (if applicable):
$ rpm -q mock
mock-1.2.0-1.fc20.noarch


How reproducible:
Always


Steps to Reproduce:
1. Set "config_opts['plugin_conf']['lvm_root_enable'] = True" in site-defaults.csf
2. But don't specify size.
3.

Actual results:
"ERROR: 'size'"

Expected results:
Sensible default size is used.

Additional info:

Comment 1 Michael Simacek 2014-11-11 17:16:55 UTC
There is no sensible default. There are people that use mock to rebuild just some small package and 1GB should be sufficient for them. On the other hand there are people who will share the pool across multiple configs and need to rebuild big packages such as libreoffice (it needs 5GB IIRC), so they will need more than 10GB. There used to be a default, but I removed it for this reason.

We agreed with Vit on IRC that it would instead be sensible to have a default for pool_name, which will result into sharing the pool across all configurations with lvm plugin enabled. Therefore the decision regarding the size will be made just once.


Note You need to log in before you can comment on or make changes to this bug.